Skip to content

linera_core::client: rely on sparse processing of certificates for batching #4770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

linera_core::client: rely on sparse processing of certificates for batching #4770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 16 additions & 25 deletions linera-core/src/client/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,35 +469,26 @@ impl<Env: Environment> Client<Env> {
certificates: Vec<ConfirmedBlockCertificate>,
) -> Result<Option<Box<ChainInfo>>, ChainClientError> {
let mut info = None;
let required_blob_ids: Vec<_> = certificates
.iter()
.flat_map(|certificate| certificate.value().required_blob_ids())
.collect();
let mut required_blob_ids = vec![];
let mut unhandled_certificates = vec![];

match self
.local_node
.read_blob_states_from_storage(&required_blob_ids)
.await
{
Err(LocalNodeError::BlobsNotFound(blob_ids)) => {
self.download_blobs(remote_node, blob_ids).await?;
}
x => {
x?;
for certificate in certificates {
// `handle_certificate` will sparsely preprocess the certificate if its
// ancestors are not available.
match self.handle_certificate(certificate.clone()).await {
Err(LocalNodeError::BlobsNotFound(blob_ids)) => {
required_blob_ids.extend(blob_ids);
unhandled_certificates.push(certificate);
}
chain_info_response => info = Some(chain_info_response?.info),
}
}

for certificate in certificates {
info = Some(
match self.handle_certificate(certificate.clone()).await {
Err(LocalNodeError::BlobsNotFound(blob_ids)) => {
self.download_blobs(remote_node, blob_ids).await?;
self.handle_certificate(certificate).await?
}
x => x?,
}
.info,
);
if !required_blob_ids.is_empty() {
self.download_blobs(remote_node, required_blob_ids).await?;
for certificate in unhandled_certificates {
info = Some(self.handle_certificate(certificate.clone()).await?.info);
}
}

// Done with all certificates.
Expand Down
Loading