Skip to content

Refactor of Scoped CSS #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
+742 −695
Open

Refactor of Scoped CSS #413

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
4214d43
refact: removal of custom razor.css, update to bootstrap 5
EliasMasche Jun 17, 2025
8c0696d
refact: removal of razor.css and update of HTML bootstrap 5
EliasMasche Jun 17, 2025
31aff69
refact: removed razor.css and updated to bootstrap 5 utility classes
EliasMasche Jun 17, 2025
29aa5df
refact: removed razor.css files
EliasMasche Jun 17, 2025
4ee70f7
Merge branch 'master' of https://github.com/linkdotnet/Blog
EliasMasche Jul 12, 2025
e47a6d8
Merge branch 'linkdotnet:master' into master
EliasMasche Jul 12, 2025
61527ac
fix: added missing `id` and `class` that caused tests to fail
EliasMasche Jul 12, 2025
6597ccd
Merge branch 'master' of https://github.com/EliasMasche/Blog
EliasMasche Jul 12, 2025
a56ffe3
fixed: visual regressions in the UI and behavior of the app with HTML…
EliasMasche Jul 13, 2025
ad549d3
Merge branch 'master' of https://github.com/linkdotnet/Blog
EliasMasche Sep 4, 2025
42ce3de
Fix: Recreated old spacing using style, override default Bootstrap value
EliasMasche Sep 5, 2025
ee7fa4c
fix: added css code for one line on the keypoints
EliasMasche Sep 5, 2025
b362fba
fix: add css class for handling of padding at nav-link
EliasMasche Sep 9, 2025
389d4c2
fix: added px-3 in html class instead of custom
EliasMasche Sep 10, 2025
eabcaf8
fix: reverted to razor.css file
EliasMasche Sep 10, 2025
4b71e59
Merge branch 'master' of https://github.com/linkdotnet/Blog
EliasMasche Sep 13, 2025
e2f9c8d
refact: removal of inline style to match bootstrap class
EliasMasche Sep 16, 2025
6085c48
Merge branch 'linkdotnet:master' into master
EliasMasche Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/LinkDotNet.Blog.Web/Features/Home/Components/NavMenu.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
@implements IDisposable

<nav class="navbar navbar-expand-lg navbar-light w-100">
<div class="container-fluid">
<div class="container-fluid" style="--bs-navbar-nav-link-padding-x: 1rem;">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we have to explicitly overwrite the bootstrap style, we are better off setting it into a custom class with higher specificity. Otherwise a minor update of bootstrap and the solution breaks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placing at#navbarSupportedContent and .nav-link the custom class for handling the padding is gonna be enough for avoiding that situation of breaking at updates?

#navbarSupportedContent .nav-link {
	padding-left: 1rem;
	padding-right: 1rem;
}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Padding-left and right would be "px-3" so you could just add that.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aka: We can stay in the bootstrap world

@if (!string.IsNullOrEmpty(Configuration.Value.BlogBrandUrl))
{
<a class="nav-brand ms-5" href="/">
Expand Down
1 change: 1 addition & 0 deletions src/LinkDotNet.Blog.Web/wwwroot/css/basic.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,7 @@ code {
.profile-keypoints li {
padding-bottom: 0.6em;
letter-spacing: 0.05em;
display: flex;
}

/* As the MarkupComponent is a base class we have to use deep */
Expand Down