Added subkind Numeric for ad hoc arithmetic operations
#1207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hew02
force-pushed
the
subkind-overload
branch
from
7cbe293 to
175be34
Compare
hew02
force-pushed
the
subkind-overload
branch
from
a41ccd2 to
941f4e9
Compare
+ Reconfigured lib.ml's arithmetic operations to use the numeric subkind as a primitive form of ad hoc polymorphism. + Moved `abs()` to `lib.ml` so it can be ad hoc by piggybacking of OCaml's type matching + The keyword `effect` is now reserved in OCaml, renamed a case in irCheck + Added a fix for the Emacs mode
hew02
force-pushed
the
subkind-overload
branch
from
c4bee1a to
655dc77
Compare
hew02
changed the title
Numeric and reconfigured lib.ml'sNumeric for ad hoc arithmetic operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still wrapping my head around Links' codebase but I felt this way of doing things was not too obtuse. I saw there was an effort to bootstrap lib so if that moves forward I assume that this work would have to be refactored. If there is a better approach I would appreciate the feedback.