-
Couldn't load subscription status.
- Fork 19
Implement NFC #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement NFC #152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for picking this up @msirringhaus!
This seems a reasonable approach. If in the future multiple backends scenarios arise, contributions to make this configurable will be welcome! |
- Create separate NFC-examples. Only compile them if NFC-features are requested - Only return the first found NFC-device - Remove left-over todo!()-macro call
|
Thank you very much @msirringhaus, this looks great! |
604b53b
into
linux-credentials:master
Very heavily based on #105, with the following additions:
select_fido2()to discover both U2F and FIDO2-only devicesNfcDevicederiveCloneand other minor tweaks, so we can easily use it incredentialsdOpen questions:
credentialsduses a poll-mechanism to find USB-devices (simply looping overlist_devices()) as well, I did not investigate to get a blocking device discovery.hidwithnfcin the USB-handler. Thus, I needed a dummyblink_and_wait_for_user_presence()-implementation. This should probably be removed, esp. if we go for the "return first device"-scheme mentioned above. But doing that, I was able to successfully use NFC-devices with Firefox.