conf.d: add *_ARCH keys for legacy targets and extend schema - #97
Conversation
lumag
left a comment
There was a problem hiding this comment.
Does RB5 (SM8250) implement ARCH_VER?
How do we handle db410c (MSM8916)? Do we need to add an empty dir for the sake of ARCH_VER configuration?
Also, please split this into sepate, logical commits.
Register ADSP_ARCH, MDSP_ARCH, SDSP_ARCH, CDSP_ARCH as optional string properties with pattern '^v[0-9a-f]+$' to validate hex-based DSP architecture version strings (e.g. v60, v65, v6a). Signed-off-by: Vinayak Katoch <vinayak.katoch@oss.qualcomm.com>
Legacy targets (db820c, db845c, qcs615-ride) do not implement the ARCH_VER capability on the DSP, so fastrpc cannot auto-detect the Hexagon version at runtime. Add the *_ARCH keys explicitly in the YAML config so fastrpc can resolve the correct DSP library search path (e.g. /usr/share/qcom/hexagon/v<XY>/). db820c: ADSP_ARCH=v60, SDSP_ARCH=v60 db845c: ADSP_ARCH=v65, CDSP_ARCH=v65, SDSP_ARCH=v65 qcs615-ride: ADSP_ARCH=v66, CDSP_ARCH=v66 Signed-off-by: Vinayak Katoch <vinayak.katoch@oss.qualcomm.com>
Yes
FastRPC lib gracefully handles cases where ARCH_VER capability is not supported by either falling back to yaml configuration or returning meaningful error code. However, how do you expect us to handle targets that are not enabled in the hexagon-dsp-binaries project?
Sure |
That's what I've asked. Do we need to add a config file for it just to let FastRPC library resolve Hexagon arch on that platform? |
Yes, we can do that adding a config file for the target should allow the library to correctly resolve the Hexagon arch path. I'll update the PR, let me know if it looks correct. |
db410c does not support ARCH_VER capability, so add ADSP_ARCH=v5 explicitly for fastrpc to resolve the correct DSP library path. Signed-off-by: Vinayak Katoch <vinayak.katoch@oss.qualcomm.com>
lumag
left a comment
There was a problem hiding this comment.
Also please explain, why we are shipping this config file, but not the actual binaries
@vkasinat, @quic-psaddam, could you please comment on whether we have binaries for db410c? If not, we can drop the config file. |
|
@quic-vkatoch there are no binaries for db410c. |
| machines: | ||
| Qualcomm Technologies, Inc. APQ 8016 SBC: | ||
| DSP_LIBRARY_PATH: apq8016/Qualcomm/db410c/dsp | ||
| ADSP_ARCH: v5 |
There was a problem hiding this comment.
Is it just v5, without any v51 or v55?
I can see FastCV and other DSP binaries going back to msm8974. If there were no separate fastrpc_shell and other system libs, then we need to provide a conf file here to let users load those DSP libs. |
Legacy targets (db820c, db845c, qcs615-ride) do not implement the ARCH_VER capability on the DSP, so fastrpc cannot auto-detect the Hexagon version at runtime. This adds explicit *_ARCH keys in the per-machine YAML configs so fastrpc can resolve the correct DSP library search path (e.g. /usr/share/qcom/hexagon/v<XY>/).
YAML changes:
Schema changes (conf.d/schema.json):
Depends on qualcomm/fastrpc#328