WIP: Pin Linuxboot to Commit and Separate EDK2 into a Separate Module #1047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making EDK2 into a module will aid in allowing it to be rebuilt (linuxboot#359) and patched by the build system and to be reproducible (linuxboot#403). It also provides somewhat of logical separation from Linuxboot. Further, Linuxboot builds have not been working with HEADS for a while because it hasn't been pinned to a commit, and therefore it changes as the repository is updated. This commit pins Linuxboot to a commit that has shown to work. Linuxboot commit: f0ea0af8609e235631f1fcb65a4f7eb69f28ea26 EDK2 commit: b7c299e4799012e8a20958a68693ab95b7626aa9
Addresses build errors in Ubuntu 20.04 (linuxboot#978)
tlaurion
added a commit
to tlaurion/heads
that referenced
this pull request
Oct 28, 2021
|
Merged CircleCI_Ubuntu2104 to a checkout of your branch that lives https://github.com/tlaurion/heads/tree/qemu-linuxboot_bringback including changes to CircleCI config to momentarily only build for qemu-linuxboot so that others can see where the build hangs on newer OSes builds. Build is happening here https://app.circleci.com/pipelines/github/tlaurion/heads/828/workflows/f05d8b94-b8b7-4bc7-af9d-1c4aebbcfaf9 |
|
@synackd previous build succeeded producing https://2111-103208611-gh.circle-artifacts.com/0/build/qemu-linuxboot/linuxboot-qemu-linuxboot-v5.0.1-62-g564e641.rom List of artifacts and logs are here: https://app.circleci.com/pipelines/github/tlaurion/heads/828/workflows/f05d8b94-b8b7-4bc7-af9d-1c4aebbcfaf9/jobs/2111/artifacts |
tlaurion
added a commit
to tlaurion/heads
that referenced
this pull request
Oct 29, 2021
…Ses (complement linuxboot#1047) append -linuxboot to save_cache and restore_cache statements to build clean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues and cleans the work in #845 by:
and other changes that are necessary to fix Linuxboot builds.