Skip to content

feat(dashboards): wire north star into ED dashboard#350

Open
mrautela365 wants to merge 3 commits intofeat/LFXV2-1220-pr4-north-starfrom
feat/LFXV2-1220-pr5-dashboard-shell
Open

feat(dashboards): wire north star into ED dashboard#350
mrautela365 wants to merge 3 commits intofeat/LFXV2-1220-pr4-north-starfrom
feat/LFXV2-1220-pr5-dashboard-shell

Conversation

@mrautela365
Copy link
Contributor

Summary

  • Import NorthStarMetricsComponent into ED dashboard shell
  • Add @defer (on idle) section with skeleton placeholder for north star metrics grid
  • After this PR merges, selecting Executive Director persona renders the full dashboard with both marketing overview and north star metrics

Context

PR 5 of 5 — the "flip the switch" PR. Trivial wiring only (34 lines changed).

Depends on: #349 (north star metrics)
PR sequence: #345#346#347#348#349 → PR 5 (this)

Build safety

  • After merge, the complete ED dashboard is live
  • All components are deferred (@defer (on idle)) with skeleton placeholders

Test plan

  • yarn build passes
  • yarn lint passes
  • License header check passes
  • Select Executive Director persona → full dashboard renders
  • Marketing cards show live Snowflake data
  • North star cards show mock data with working drawers

LFXV2-1220

🤖 Generated with Claude Code

@coderabbitai
Copy link

coderabbitai bot commented Mar 19, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 80476d76-15c2-44f3-9cfc-2c78abf78eca

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/LFXV2-1220-pr5-dashboard-shell
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Mar 19, 2026

🚀 Deployment Status

Your branch has been deployed to: https://ui-pr-350.dev.v2.cluster.linuxfound.info

Deployment Details:

  • Environment: Development
  • Namespace: ui-pr-350
  • ArgoCD App: ui-pr-350

The deployment will be automatically removed when this PR is closed.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Wires the previously added North Star metrics section into the Executive Director (ED) dashboard shell, using Angular deferred loading with a skeleton placeholder to keep initial render lightweight.

Changes:

  • Import NorthStarMetricsComponent into the ED dashboard standalone component imports.
  • Render the north star metrics section in the ED dashboard template inside @defer (on idle) with a 4-card skeleton placeholder.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
apps/lfx-one/src/app/modules/dashboards/executive-director/executive-director-dashboard.component.ts Adds NorthStarMetricsComponent to the component’s imports so it can be used in the ED dashboard template.
apps/lfx-one/src/app/modules/dashboards/executive-director/executive-director-dashboard.component.html Adds a deferred North Star metrics section with a skeleton placeholder, placed above the marketing overview section.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mrautela365 mrautela365 force-pushed the feat/LFXV2-1220-pr4-north-star branch from d63a5c5 to d991cd6 Compare March 20, 2026 00:05
@mrautela365 mrautela365 force-pushed the feat/LFXV2-1220-pr5-dashboard-shell branch from 90fc956 to 669c68e Compare March 20, 2026 00:05
@mrautela365 mrautela365 force-pushed the feat/LFXV2-1220-pr4-north-star branch from d991cd6 to 7e3e507 Compare March 20, 2026 00:14
@mrautela365 mrautela365 force-pushed the feat/LFXV2-1220-pr5-dashboard-shell branch from 669c68e to 8a0b361 Compare March 20, 2026 00:15
@mrautela365 mrautela365 force-pushed the feat/LFXV2-1220-pr4-north-star branch from 7e3e507 to 7ddb0e8 Compare March 20, 2026 00:21
@mrautela365 mrautela365 force-pushed the feat/LFXV2-1220-pr5-dashboard-shell branch from 8a0b361 to e2f6b01 Compare March 20, 2026 00:22
@mrautela365 mrautela365 force-pushed the feat/LFXV2-1220-pr4-north-star branch from 7ddb0e8 to ba5164f Compare March 20, 2026 01:04
@mrautela365 mrautela365 force-pushed the feat/LFXV2-1220-pr5-dashboard-shell branch from e2f6b01 to c3d765b Compare March 20, 2026 01:05
@mrautela365 mrautela365 force-pushed the feat/LFXV2-1220-pr4-north-star branch from ba5164f to 21e08f9 Compare March 20, 2026 01:09
@mrautela365 mrautela365 force-pushed the feat/LFXV2-1220-pr5-dashboard-shell branch from c3d765b to 9637775 Compare March 20, 2026 01:10
@mrautela365 mrautela365 force-pushed the feat/LFXV2-1220-pr5-dashboard-shell branch from fc269f7 to 1ea3011 Compare March 20, 2026 02:32
@mrautela365 mrautela365 force-pushed the feat/LFXV2-1220-pr4-north-star branch from ba5fc95 to 3b72549 Compare March 20, 2026 02:40
@mrautela365 mrautela365 force-pushed the feat/LFXV2-1220-pr5-dashboard-shell branch from 1ea3011 to f7d22f4 Compare March 20, 2026 02:40
@mrautela365 mrautela365 force-pushed the feat/LFXV2-1220-pr4-north-star branch from 3b72549 to 783508b Compare March 20, 2026 02:45
@mrautela365 mrautela365 force-pushed the feat/LFXV2-1220-pr5-dashboard-shell branch from f7d22f4 to 0f545c9 Compare March 20, 2026 02:45
@mrautela365 mrautela365 force-pushed the feat/LFXV2-1220-pr5-dashboard-shell branch from 0f545c9 to 8ed951e Compare March 20, 2026 02:54
@mrautela365 mrautela365 force-pushed the feat/LFXV2-1220-pr5-dashboard-shell branch from 8ed951e to af333f4 Compare March 20, 2026 03:08
@mrautela365 mrautela365 force-pushed the feat/LFXV2-1220-pr4-north-star branch from 0c5a695 to 28d30fe Compare March 20, 2026 03:08
@mrautela365 mrautela365 force-pushed the feat/LFXV2-1220-pr5-dashboard-shell branch from af333f4 to cdf4e23 Compare March 20, 2026 03:18
@mrautela365 mrautela365 force-pushed the feat/LFXV2-1220-pr4-north-star branch from 28d30fe to b44c776 Compare March 20, 2026 03:18
@mrautela365 mrautela365 force-pushed the feat/LFXV2-1220-pr5-dashboard-shell branch from cdf4e23 to 2d57017 Compare March 20, 2026 03:34
@mrautela365 mrautela365 force-pushed the feat/LFXV2-1220-pr4-north-star branch from b44c776 to 0f05003 Compare March 20, 2026 03:34
@mrautela365 mrautela365 force-pushed the feat/LFXV2-1220-pr4-north-star branch from 0f05003 to 44b6f4e Compare March 20, 2026 03:56
@mrautela365 mrautela365 force-pushed the feat/LFXV2-1220-pr5-dashboard-shell branch from 2d57017 to 67c048e Compare March 20, 2026 04:01
@mrautela365 mrautela365 force-pushed the feat/LFXV2-1220-pr4-north-star branch from 44b6f4e to fa99306 Compare March 20, 2026 04:15
@mrautela365 mrautela365 force-pushed the feat/LFXV2-1220-pr5-dashboard-shell branch from fefeffa to ad02b7b Compare March 20, 2026 04:15
@mrautela365 mrautela365 force-pushed the feat/LFXV2-1220-pr4-north-star branch from fa99306 to 3eb512a Compare March 20, 2026 04:35
mrautela365 and others added 3 commits March 19, 2026 22:39
Import NorthStarMetricsComponent and add deferred section to the
executive director dashboard shell.

LFXV2-1220

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Misha Rautela <mrautela@linuxfoundation.org>
Rebase conflict resolution reverted paid-social-reach and
social-media drawers to old static array pattern. Restore the
correct computed Signal<> pattern with initRecommendedActions()
and initKeyInsights() methods that compute from input data.

LFXV2-1220

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Misha Rautela <mrautela@linuxfoundation.org>
Apply QA fixes: computed signals for template formatNumber calls, flat
arrow guard on 0% change, ROAS always-visible display, backend try/catch
wrappers, null safety, JSDoc, and formatNumber threshold alignment.

LFXV2-1220

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Misha Rautela <mrautela@linuxfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants