feat(dashboards): wire north star into ED dashboard#350
feat(dashboards): wire north star into ED dashboard#350mrautela365 wants to merge 3 commits intofeat/LFXV2-1220-pr4-north-starfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
🚀 Deployment StatusYour branch has been deployed to: https://ui-pr-350.dev.v2.cluster.linuxfound.info Deployment Details:
The deployment will be automatically removed when this PR is closed. |
There was a problem hiding this comment.
Pull request overview
Wires the previously added North Star metrics section into the Executive Director (ED) dashboard shell, using Angular deferred loading with a skeleton placeholder to keep initial render lightweight.
Changes:
- Import
NorthStarMetricsComponentinto the ED dashboard standalone component imports. - Render the north star metrics section in the ED dashboard template inside
@defer (on idle)with a 4-card skeleton placeholder.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/lfx-one/src/app/modules/dashboards/executive-director/executive-director-dashboard.component.ts | Adds NorthStarMetricsComponent to the component’s imports so it can be used in the ED dashboard template. |
| apps/lfx-one/src/app/modules/dashboards/executive-director/executive-director-dashboard.component.html | Adds a deferred North Star metrics section with a skeleton placeholder, placed above the marketing overview section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d63a5c5 to
d991cd6
Compare
90fc956 to
669c68e
Compare
d991cd6 to
7e3e507
Compare
669c68e to
8a0b361
Compare
7e3e507 to
7ddb0e8
Compare
8a0b361 to
e2f6b01
Compare
7ddb0e8 to
ba5164f
Compare
e2f6b01 to
c3d765b
Compare
ba5164f to
21e08f9
Compare
c3d765b to
9637775
Compare
fc269f7 to
1ea3011
Compare
ba5fc95 to
3b72549
Compare
1ea3011 to
f7d22f4
Compare
3b72549 to
783508b
Compare
f7d22f4 to
0f545c9
Compare
0f545c9 to
8ed951e
Compare
8ed951e to
af333f4
Compare
0c5a695 to
28d30fe
Compare
af333f4 to
cdf4e23
Compare
28d30fe to
b44c776
Compare
cdf4e23 to
2d57017
Compare
b44c776 to
0f05003
Compare
0f05003 to
44b6f4e
Compare
2d57017 to
67c048e
Compare
44b6f4e to
fa99306
Compare
fefeffa to
ad02b7b
Compare
fa99306 to
3eb512a
Compare
Import NorthStarMetricsComponent and add deferred section to the executive director dashboard shell. LFXV2-1220 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Misha Rautela <mrautela@linuxfoundation.org>
Rebase conflict resolution reverted paid-social-reach and social-media drawers to old static array pattern. Restore the correct computed Signal<> pattern with initRecommendedActions() and initKeyInsights() methods that compute from input data. LFXV2-1220 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Misha Rautela <mrautela@linuxfoundation.org>
Apply QA fixes: computed signals for template formatNumber calls, flat arrow guard on 0% change, ROAS always-visible display, backend try/catch wrappers, null safety, JSDoc, and formatNumber threshold alignment. LFXV2-1220 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Misha Rautela <mrautela@linuxfoundation.org>
Summary
NorthStarMetricsComponentinto ED dashboard shell@defer (on idle)section with skeleton placeholder for north star metrics gridContext
PR 5 of 5 — the "flip the switch" PR. Trivial wiring only (34 lines changed).
Depends on: #349 (north star metrics)
PR sequence: #345 → #346 → #347 → #348 → #349 → PR 5 (this)
Build safety
@defer (on idle)) with skeleton placeholdersTest plan
yarn buildpassesyarn lintpassesLFXV2-1220
🤖 Generated with Claude Code