Skip to content

fix: the continue loop error in the device selection logic #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtwebster merged 1 commit into from
Dec 8, 2025
+1 −1
Merged

fix: the continue loop error in the device selection logic #456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/AppConsole.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,7 +1069,7 @@ public class AppConsole : GLib.Object {
}

dev = read_stdin_device(device_list, grub_device_default);
if (dev != null) { continue; }
if (dev != null) { break; }
Copy link
Member

@mtwebster mtwebster Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in this comment, couldn't you assign to App.grub_device here and let the loop naturally exit?

Copy link
Contributor Author

@ys928 ys928 Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I am not familiar with this project and only discovered this issue while using the program. And even after repeating this logic three times, the program still runs normally, so the length of App. grub_device seems insignificant? Even though it was 0, the backup operation was still performed normally, so I used the simplest repair method

}

if (dev == null){
Expand Down