-
-
Notifications
You must be signed in to change notification settings - Fork 265
Enable configurable DNS propagation time for Azure DNS plugin #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this pull request! Be sure to follow the pull request template!
I am a bot, here is the pushed image/manifest for this PR:
|
I am a bot, here is the pushed image/manifest for this PR:
|
I see an issue terricain/certbot-dns-azure#1 which is closed but shows log output with the propagation flag to be unsupported. Later someone reported terricain/certbot-dns-azure#36 which shows log output that looks like the propagation flag is supported, so I think it's safe to assume this should be fine. |
I'd like #564 to merge first and then this would need a changelog entry in the |
I am a bot, here is the pushed image/manifest for this PR:
|
I am a bot, here is the pushed image/manifest for this PR:
|
I am a bot, here is the pushed image/manifest for this PR:
|
Description:
Add support for the PROPAGATION environment variable to the Azure DNS plugin, allowing configurable wait times for DNS record propagation.
Benefits of this PR and context:
Prior to this change, the Azure DNS plugin ignored propagation delays and could fail DNS-01 challenges when records hadn’t yet propagated. By honoring the PROPAGATION setting, the plugin now behaves consistently with Certbot’s propagation mechanism and aligns with other DNS providers.
How Has This Been Tested?
After confirming that the Azure DNS plugin supports configurable propagation time with Certbot, I removed it from the list of DNS plugins that lack propagation-time support. Then I cleared the letsencrypt folder, requested a new certificate, and reviewed the logs to verify that the propagation delay was applied correctly.
Source / References: