Skip to content

Conversation

@underfake
Copy link
Contributor

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Add support for the PROPAGATION environment variable to the Azure DNS plugin, allowing configurable wait times for DNS record propagation.

Benefits of this PR and context:

Prior to this change, the Azure DNS plugin ignored propagation delays and could fail DNS-01 challenges when records hadn’t yet propagated. By honoring the PROPAGATION setting, the plugin now behaves consistently with Certbot’s propagation mechanism and aligns with other DNS providers.

How Has This Been Tested?

After confirming that the Azure DNS plugin supports configurable propagation time with Certbot, I removed it from the list of DNS plugins that lack propagation-time support. Then I cleared the letsencrypt folder, requested a new certificate, and reviewed the logs to verify that the propagation delay was applied correctly.

Source / References:

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-swag:4.0.0-pkg-9908bd4f-dev-a5f1da0bcf445568ca296511a328defd5e13879b-pr-562

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-swag:4.0.0-pkg-712d67a0-dev-868ece1e6bad12523a5b68959cf4a3f64d4f1234-pr-562

@nemchik
Copy link
Member

nemchik commented May 5, 2025

I see an issue terricain/certbot-dns-azure#1 which is closed but shows log output with the propagation flag to be unsupported. Later someone reported terricain/certbot-dns-azure#36 which shows log output that looks like the propagation flag is supported, so I think it's safe to assume this should be fine.

@nemchik
Copy link
Member

nemchik commented May 5, 2025

I'd like #564 to merge first and then this would need a changelog entry in the readme-vars.yml file and can merge.

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-swag:4.0.0-pkg-82f9fcd7-dev-e65a665e184036ff8c97ea92279135082f1f6c31-pr-562

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-swag:4.1.1-pkg-c0f258a9-dev-7d7e926489e190af3a4ba0d02085e2db961fcae4-pr-562

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-swag:4.1.1-pkg-568a10c5-dev-cb2c4548568c3db393433810eb9407d536f134dd-pr-562

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-swag:4.2.0-pkg-ffef3026-dev-3c52d33b1d532389807ad45d198127d61bd7b70a-pr-562

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-swag:5.0.0-pkg-2deef27a-dev-0dfba50e11e5b0cfce68505a6bf1cee30783e7d2-pr-562

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-swag:5.1.0-pkg-d6208c74-dev-0e8c6dd20ac377f159c71ab23a47e11532d21f86-pr-562

@github-project-automation github-project-automation bot moved this from PRs to PRs Approved in Issue & PR Tracker Nov 5, 2025
@nemchik nemchik merged commit 23dd053 into linuxserver:master Nov 5, 2025
6 checks passed
@LinuxServer-CI LinuxServer-CI moved this from PRs Approved to Done in Issue & PR Tracker Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants