Fix macOS compilation issues - #1074
Conversation
for clang and library compatibility This commit addresses compilation issues encountered when building on MacBook M5 (Apple Silicon) as well as some issues compiling on an older Intel based MacBook. These use clang instead of gcc, and adapts to different library versions available on macOS. Changes include: - scrypt: Add macOS-specific endian.h include and guard endian functions for Apple platforms to use system implementations - wallet: Add Boost version checks for filesystem API compatibility across different Boost versions - build system: Update configure.ac and boost m4 macros for macOS compatibility - docs: Update build-osx.md with the latest build instructions - macdeploy: Update macdeployqtplus script for compatibility when some translation files are not available. These changes ensure the codebase compiles successfully with clang on Apple Silicon while maintaining compatibility with existing platforms.
|
@luke-mckay can you try a gitian build with these changes please? have a look at https://github.com/DavidBurkett/ltc-release-builder which should make it easier. |
|
I'll take a look. Sorry for the delay. |
|
I have confirmed that this breaks the release build. Now that I've circled back to this it shouldn't take me long to investigate a new solution. |
|
@zorkcoin-dev are you saying luke's patch breaks your build? |
|
I also confirmed it breaks the release. Before even looking at a fix I was going to see if the release even works on Apple Silicon? I hadn't ever actually just ran a release on the new system. I figured it might be that another binary would need added to the release, but I've been slow with this stuff. if @zorkcoin-dev has more info that might be helpful too. |
4 participants
This commit addresses compilation issues encountered when building on MacBook M5 (Apple Silicon) as well as some issues compiling on an older Intel based MacBook. These use clang instead of gcc, and adapts to different library versions available on macOS.
Changes include:
These changes ensure the codebase compiles successfully with clang on Apple Silicon while maintaining compatibility with existing platforms.
Closes #1073
I have not tried cross compiles, where the mac build is performed on linux. I have not tried or validated whatever release process is used for Litecoin Core. I have only built on two different MacBooks with the latest OS for each one. I'd suggest some others perform some testing on these if they are to be considered to be integrated.