Detect Chromium Edge with the plugin @chiragrupani/karma-chromium-edge-launcher #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleen42
force-pushed
the
chromium-edge
branch
4 times, most recently
from
681b785 to
ae3b6da
Compare
aleen42
changed the title
aleen42
force-pushed
the
chromium-edge
branch
2 times, most recently
from
db286ef to
9d83604
Compare
aleen42
changed the title
aleen42
force-pushed
the
chromium-edge
branch
2 times, most recently
from
9101780 to
1058fb7
Compare
|
@litixadmin friendly ping. This would be very useful since Edge CHromium is now default installed on Windows. |
|
The repo is not maintained any more. Feel free to fork the repo. |
aleen42
force-pushed
the
chromium-edge
branch
2 times, most recently
from
95e7d9a to
325d5e5
Compare
aleen42
force-pushed
the
chromium-edge
branch
from
325d5e5 to
70ba502
Compare
|
@aleen42 could you maybe publish your changes on npm? |
|
If so, I can investigate if the fork can be used for karma-runner/karma-edge-launcher#11. If it's simple enough I'll try it, otherwise I'll be open to PRs. |
|
@XhmikosR You can try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we knew Microsoft has used a new Edge based on Chromium by default, and I want your plugin to try to detect via the plugin @chiragrupani/karma-chromium-edge-launcher according to karma-runner/karma-edge-launcher#11.
At the same time, it may be a better way for compatibility when integrating this plugin with
karma-edge-launcher.