feat(simulate): record the CI pipeline a run came from - #955
Draft
u9g wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records the CI pipeline a simulation run came from, so a run in the Cloud dashboard links back to the pipeline job that started it.
lk agent simulatenow fills in the run's CI provenance — commit, ref, pull request, run URL, actor — automatically when it detects it is running under GitHub Actions. Detection is silent and there is no new flag: GitHub Actions setsGITHUB_ACTIONSitself, and a run outside a pipeline simply sends nothing.On a
pull_requesteventGITHUB_REF_NAMEis<number>/merge, which names the merge ref rather than the branch, soGITHUB_HEAD_REFis preferred where it is set.Only GitHub Actions is detected. Other providers each need their own environment mapping and URL construction, which cannot be tested here.
Blocked
Needs a
github.com/livekit/protocolrelease containingSimulationRun.CI(livekit/protocol#1758). Draft until then — this will not build against protocol main.Verification
Verified against a local
replacepointing at the protocol branch:go build ./...clean,go test ./cmd/lk/...passing, including a new test covering the pull-request ref case and the absent-CI case. Thereplacewas reverted and is not part of this commit.