allow passing in TLS connector #755
Open
+65
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been through a number of different possible rustls connectors, and we're currently using one (rustls-platform-verifier) that doesn't have feature flags in livekit or tungstenite yet. Instead of requiring that every transitive dependency supports the rustls feature flags we need, it's much easier to pass only the __rustls-tls feature flag and pass the Connector that we create with our configuration down the stack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #609 rebased on the current main branch. The dependency updates have been split to #754.
From the original PR:
We've been through a number of different possible rustls connectors, and we're currently using one (rustls-platform-verifier) that doesn't have feature flags in livekit or tungstenite yet.
Instead of requiring that every transitive dependency supports the rustls feature flags we need, it's much easier to pass only the __rustls-tls feature flag and pass the Connector that we create with our configuration down the stack.