[FIRRTL] FIRParser: parse tagExtract operations #8728
+29
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngar
force-pushed
the
firrtl-enum-tagextract-parsing
branch
2 times, most recently
from
2bacd94 to
1e1a6ce
Compare
youngar
commented
Jul 17, 2025
Comment on lines
3979
to
3983
| // Check argument is an enum-type value. | ||
| if (!type_isa<FEnumType>(input.getType())) | ||
| return emitError(startTok.getLoc(), | ||
| "expected enum-type expression in 'tagExtract', got ") | ||
| << input.getType(); |
There was a problem hiding this comment.
Its not clear to me if we should be checking this here or relying on the op verifiers. I think I will remove this check for now.
youngar
force-pushed
the
firrtl-enum-tagextract-parsing
branch
from
1e1a6ce to
970dbec
Compare
youngar
commented
Jul 17, 2025
Comment on lines
2129
to
2130
| if (isLeadingStmt) | ||
| return emitError("unexpected tagExtract() as start of statement"); |
There was a problem hiding this comment.
I don't think I need this but its a little unclear. Without it you get a flow checking error.
youngar
commented
Jul 17, 2025
Comment on lines
+2127
to
+2128
| if (requireFeature(missingSpecFIRVersion, "tagExtract")) | ||
| return failure(); |
There was a problem hiding this comment.
It would be nice to parse this as a prim op and save some typing, but then you can't check for the spec version.
youngar
force-pushed
the
firrtl-enum-tagextract-parsing
branch
from
970dbec to
d874be1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #8724