Invert the enum logic like TuneNoDefaultUnroll does

Instead of using NoMISchedLoadClustering and setting it to 'true' using
the feature, rename it to NoMISchedLoadClustering and make the feature
set it to 'false'.

Rename the subtarget method disableMISchedLoadClustering() to
enableMISchedLoadClustering() to remove the negative check in
createMachineScheduler() when enabling the clustering.

Do the same with the other 3 subtarget features.

Author: danielhb

llvm/lib/Target/RISCV/RISCVFeatures.td

@@ -1701,16 +1701,16 @@ def TunePostRAScheduler : SubtargetFeature<"use-postra-scheduler",
     "UsePostRAScheduler", "true", "Schedule again after register allocation">;
 
 def TuneDisableMISchedLoadClustering : SubtargetFeature<"disable-misched-load-clustering",
-    "NoMISchedLoadClustering", "true", "Disable load clustering in the machine scheduler">;
+    "MISchedLoadClustering", "false", "Disable load clustering in the machine scheduler">;
 
 def TuneDisableMISchedStoreClustering : SubtargetFeature<"disable-misched-store-clustering",
-    "NoMISchedStoreClustering", "true", "Disable store clustering in the machine scheduler">;
+    "MISchedStoreClustering", "false", "Disable store clustering in the machine scheduler">;
 
 def TuneDisablePostMISchedLoadClustering : SubtargetFeature<"disable-postmisched-load-clustering",
-    "NoPostMISchedLoadClustering", "true", "Disable PostRA load clustering in the machine scheduler">;
+    "PostMISchedLoadClustering", "false", "Disable PostRA load clustering in the machine scheduler">;
 
 def TuneDisablePostMISchedStoreClustering : SubtargetFeature<"disable-postmisched-store-clustering",
-    "NoPostMISchedStoreClustering", "true", "Disable PostRA store clustering in the machine scheduler">;
+    "PostMISchedStoreClustering", "false", "Disable PostRA store clustering in the machine scheduler">;
 
 def TuneDisableLatencySchedHeuristic
     : SubtargetFeature<"disable-latency-sched-heuristic", "DisableLatencySchedHeuristic", "true",

llvm/lib/Target/RISCV/RISCVSubtarget.h

@@ -150,13 +150,13 @@ class RISCVSubtarget : public RISCVGenSubtargetInfo {
 
   bool enablePostRAScheduler() const override { return UsePostRAScheduler; }
 
-  bool disableMISchedLoadClustering() const { return NoMISchedLoadClustering; }
+  bool enableMISchedLoadClustering() const { return MISchedLoadClustering; }
 
-  bool disableMISchedStoreClustering() const { return NoMISchedStoreClustering; }
+  bool enableMISchedStoreClustering() const { return MISchedStoreClustering; }
 
-  bool disablePostMISchedLoadClustering() const { return NoPostMISchedLoadClustering; }
+  bool enablePostMISchedLoadClustering() const { return PostMISchedLoadClustering; }
 
-  bool disablePostMISchedStoreClustering() const { return NoPostMISchedStoreClustering; }
+  bool enablePostMISchedStoreClustering() const { return PostMISchedStoreClustering; }
 
   Align getPrefFunctionAlignment() const {
     return Align(TuneInfo->PrefFunctionAlignment);

llvm/lib/Target/RISCV/RISCVTargetMachine.cpp

@@ -287,11 +287,11 @@ RISCVTargetMachine::createMachineScheduler(MachineSchedContext *C) const {
   const RISCVSubtarget &ST = C->MF->getSubtarget<RISCVSubtarget>();
   ScheduleDAGMILive *DAG = createSchedLive(C);
 
-  if (!ST.disableMISchedLoadClustering())
+  if (ST.enableMISchedLoadClustering())
     DAG->addMutation(createLoadClusterDAGMutation(
         DAG->TII, DAG->TRI, /*ReorderWhileClustering=*/true));
 
-  if (!ST.disableMISchedStoreClustering())
+  if (ST.enableMISchedStoreClustering())
     DAG->addMutation(createStoreClusterDAGMutation(
         DAG->TII, DAG->TRI, /*ReorderWhileClustering=*/true));
 
@@ -306,11 +306,11 @@ RISCVTargetMachine::createPostMachineScheduler(MachineSchedContext *C) const {
   const RISCVSubtarget &ST = C->MF->getSubtarget<RISCVSubtarget>();
   ScheduleDAGMI *DAG = createSchedPostRA(C);
 
-  if (!ST.disablePostMISchedLoadClustering())
+  if (ST.enablePostMISchedLoadClustering())
     DAG->addMutation(createLoadClusterDAGMutation(
         DAG->TII, DAG->TRI, /*ReorderWhileClustering=*/true));
 
-  if (!ST.disablePostMISchedStoreClustering())
+  if (ST.enablePostMISchedStoreClustering())
     DAG->addMutation(createStoreClusterDAGMutation(
         DAG->TII, DAG->TRI, /*ReorderWhileClustering=*/true));