Address some of the feedback

Author: rofirrim

clang/include/clang/AST/OpenMPClause.h

@@ -1154,36 +1154,34 @@ class OMPFullClause final : public OMPNoChildClause<llvm::omp::OMPC_full> {
 ///   for(int k = 127; k >= 0; --k)
 /// \endcode
 class OMPLoopRangeClause final
-    : public OMPClause,
-      private llvm::TrailingObjects<OMPLoopRangeClause, Expr *> {
+    : public OMPClause {
   friend class OMPClauseReader;
-  friend class llvm::TrailingObjects<OMPLoopRangeClause, Expr *>;
-
   /// Location of '('
   SourceLocation LParenLoc;
 
   /// Location of first and count expressions
   SourceLocation FirstLoc, CountLoc;
 
   /// Number of looprange arguments (always 2: first, count)
-  unsigned NumArgs = 2;
+  static constexpr unsigned NumArgs = 2;
+  Stmt *Args[NumArgs] = {nullptr, nullptr};
 
-  /// Set the argument expressions.
-  void setArgs(ArrayRef<Expr *> Args) {
-    assert(Args.size() == NumArgs && "Expected exactly 2 looprange arguments");
-    std::copy(Args.begin(), Args.end(), getTrailingObjects<Expr *>());
-  }
+  /// Set looprange 'first' expression
+  void setFirst(Expr *E) { Args[0] = E; }
+
+  /// Set looprange 'count' expression
+  void setCount(Expr *E) { Args[1] = E; }
 
   /// Build an empty clause for deserialization.
   explicit OMPLoopRangeClause()
-      : OMPClause(llvm::omp::OMPC_looprange, {}, {}), NumArgs(2) {}
+      : OMPClause(llvm::omp::OMPC_looprange, {}, {}) {}
 
 public:
   /// Build a 'looprange' clause AST node.
   static OMPLoopRangeClause *
   Create(const ASTContext &C, SourceLocation StartLoc, SourceLocation LParenLoc,
          SourceLocation FirstLoc, SourceLocation CountLoc,
-         SourceLocation EndLoc, ArrayRef<Expr *> Args);
+         SourceLocation EndLoc, Expr* First, Expr* Count);
 
   /// Build an empty 'looprange' clause node.
   static OMPLoopRangeClause *CreateEmpty(const ASTContext &C);
@@ -1198,32 +1196,16 @@ class OMPLoopRangeClause final
   void setCountLoc(SourceLocation Loc) { CountLoc = Loc; }
 
   /// Get looprange 'first' expression
-  Expr *getFirst() const { return getArgs()[0]; }
+  Expr *getFirst() const { return cast_or_null<Expr>(Args[0]); }
 
   /// Get looprange 'count' expression
-  Expr *getCount() const { return getArgs()[1]; }
-
-  /// Set looprange 'first' expression
-  void setFirst(Expr *E) { getArgs()[0] = E; }
-
-  /// Set looprange 'count' expression
-  void setCount(Expr *E) { getArgs()[1] = E; }
-
-  MutableArrayRef<Expr *> getArgs() {
-    return MutableArrayRef<Expr *>(getTrailingObjects<Expr *>(), NumArgs);
-  }
-  ArrayRef<Expr *> getArgs() const {
-    return ArrayRef<Expr *>(getTrailingObjects<Expr *>(), NumArgs);
-  }
+  Expr *getCount() const { return cast_or_null<Expr>(Args[1]); }
 
   child_range children() {
-    return child_range(reinterpret_cast<Stmt **>(getArgs().begin()),
-                       reinterpret_cast<Stmt **>(getArgs().end()));
+    return child_range(Args, Args + NumArgs);
   }
   const_child_range children() const {
-    auto AR = getArgs();
-    return const_child_range(reinterpret_cast<Stmt *const *>(AR.begin()),
-                             reinterpret_cast<Stmt *const *>(AR.end()));
+    return const_child_range(Args, Args + NumArgs);
   }
 
   child_range used_children() {

clang/include/clang/Sema/SemaOpenMP.h

@@ -1494,7 +1494,7 @@ class SemaOpenMP : public SemaBase {
       SmallVectorImpl<OMPLoopBasedDirective::HelperExprs> &LoopHelpers,
       Stmt *&Body, SmallVectorImpl<SmallVector<Stmt *>> &OriginalInits);
 
-  /// @brief Categories of loops encountered during semantic OpenMP loop
+  /// Categories of loops encountered during semantic OpenMP loop
   /// analysis
   ///
   /// This enumeration identifies the structural category of a loop or sequence

clang/lib/AST/OpenMPClause.cpp

@@ -1028,23 +1028,20 @@ OMPLoopRangeClause *
 OMPLoopRangeClause::Create(const ASTContext &C, SourceLocation StartLoc,
                            SourceLocation LParenLoc, SourceLocation FirstLoc,
                            SourceLocation CountLoc, SourceLocation EndLoc,
-                           ArrayRef<Expr *> Args) {
-
-  assert(Args.size() == 2 &&
-         "looprange clause must have exactly two arguments");
+                           Expr *First, Expr* Count) {
   OMPLoopRangeClause *Clause = CreateEmpty(C);
   Clause->setLocStart(StartLoc);
   Clause->setLParenLoc(LParenLoc);
   Clause->setFirstLoc(FirstLoc);
   Clause->setCountLoc(CountLoc);
   Clause->setLocEnd(EndLoc);
-  Clause->setArgs(Args);
+  Clause->setFirst(First);
+  Clause->setCount(Count);
   return Clause;
 }
 
 OMPLoopRangeClause *OMPLoopRangeClause::CreateEmpty(const ASTContext &C) {
-  void *Mem = C.Allocate(totalSizeToAlloc<Expr *>(2));
-  return new (Mem) OMPLoopRangeClause();
+  return new (C) OMPLoopRangeClause();
 }
 
 OMPAllocateClause *OMPAllocateClause::Create(

clang/lib/Sema/SemaOpenMP.cpp

@@ -14195,29 +14195,29 @@ StmtResult SemaOpenMP::ActOnOpenMPTargetTeamsDistributeSimdDirective(
 }
 
 /// Overloaded base case function
-template <typename T, typename F> static bool tryHandleAs(T *t, F &&) {
+template <typename T, typename F> static bool tryHandleAs(T *, F &&) {
   return false;
 }
 
-/// Tries to recursively cast `t` to one of the given types and invokes `f` if
-/// successful.
+/// Tries to recursively cast `Type` to one of the given types and invokes
+/// `Func` if successful.
 ///
-/// @tparam Class The first type to check.
-/// @tparam Rest The remaining types to check.
-/// @tparam T The base type of `t`.
-/// @tparam F The callable type for the function to invoke upon a successful
+/// \tparam Class The first type to check.
+/// \tparam Rest The remaining types to check.
+/// \tparam T The base type of `Type`.
+/// \tparam F The callable type for the function to invoke upon a successful
 /// cast.
-/// @param t The object to be checked.
-/// @param f The function to invoke if `t` matches `Class`.
-/// @return `true` if `t` matched any type and `f` was called, otherwise
+/// \param Type The object to be checked.
+/// \param Func The function to invoke if `Type` matches `Class`.
+/// \return `true` if `Type` matched any type and `Func` was called, otherwise
 /// `false`.
 template <typename Class, typename... Rest, typename T, typename F>
-static bool tryHandleAs(T *t, F &&f) {
-  if (Class *c = dyn_cast<Class>(t)) {
-    f(c);
+static bool tryHandleAs(T *Type, F &&Func) {
+  if (Class *C = dyn_cast<Class>(Type)) {
+    Func(C);
     return true;
   }
-  return tryHandleAs<Rest...>(t, std::forward<F>(f));
+  return tryHandleAs<Rest...>(Type, std::forward<F>(Func));
 }
 
 /// Updates OriginalInits by checking Transform against loop transformation
@@ -14297,7 +14297,7 @@ bool SemaOpenMP::checkTransformableLoopNest(
 ///     }
 /// }
 /// Result: Loop 'i' contains 2 loops, Loop 'r' also contains 2 loops
-class NestedLoopCounterVisitor : public DynamicRecursiveASTVisitor {
+class NestedLoopCounterVisitor final : public DynamicRecursiveASTVisitor {
 private:
   unsigned NestedLoopCount = 0;
 
@@ -14385,22 +14385,21 @@ bool SemaOpenMP::analyzeLoopSequence(
         LoopSeqSize += NumGeneratedLoopNests;
         NumLoops += NumGeneratedLoops;
         return true;
-      } else {
-        // Unroll full (0 loops produced)
-        Diag(Child->getBeginLoc(), diag::err_omp_not_for)
-            << 0 << getOpenMPDirectiveName(Kind);
-        return false;
       }
+      // Unroll full (0 loops produced)
+      Diag(Child->getBeginLoc(), diag::err_omp_not_for)
+          << 0 << getOpenMPDirectiveName(Kind);
+      return false;
     }
     // Handle loop transformations with multiple loop nests
     // Unroll full
-    if (NumGeneratedLoopNests <= 0) {
+    if (!NumGeneratedLoopNests) {
       Diag(Child->getBeginLoc(), diag::err_omp_not_for)
           << 0 << getOpenMPDirectiveName(Kind);
       return false;
     }
     // Loop transformatons such as split or loopranged fuse
-    else if (NumGeneratedLoopNests > 1) {
+    if (NumGeneratedLoopNests > 1) {
       // Get the preinits related to this loop sequence generating
       // loop transformation (i.e loopranged fuse, split...)
       LoopSequencePreInits.emplace_back();
@@ -14413,30 +14412,29 @@ bool SemaOpenMP::analyzeLoopSequence(
                                  LoopHelpers, ForStmts, OriginalInits,
                                  TransformsPreInits, LoopSequencePreInits,
                                  LoopCategories, Context, Kind);
-    } else {
-      // Vast majority: (Tile, Unroll, Stripe, Reverse, Interchange, Fuse all)
-      // Process the transformed loop statement
-      OriginalInits.emplace_back();
-      TransformsPreInits.emplace_back();
-      LoopHelpers.emplace_back();
-      LoopCategories.push_back(OMPLoopCategory::TransformSingleLoop);
-
-      unsigned IsCanonical =
-          checkOpenMPLoop(Kind, nullptr, nullptr, TransformedStmt, SemaRef,
-                          *DSAStack, TmpDSA, LoopHelpers[LoopSeqSize]);
-
-      if (!IsCanonical) {
-        Diag(TransformedStmt->getBeginLoc(), diag::err_omp_not_canonical_loop)
-            << getOpenMPDirectiveName(Kind);
-        return false;
-      }
-      StoreLoopStatements(TransformedStmt);
-      updatePreInits(LoopTransform, TransformsPreInits);
+    }
+    // Vast majority: (Tile, Unroll, Stripe, Reverse, Interchange, Fuse all)
+    // Process the transformed loop statement
+    OriginalInits.emplace_back();
+    TransformsPreInits.emplace_back();
+    LoopHelpers.emplace_back();
+    LoopCategories.push_back(OMPLoopCategory::TransformSingleLoop);
 
-      NumLoops += NumGeneratedLoops;
-      ++LoopSeqSize;
-      return true;
+    unsigned IsCanonical =
+        checkOpenMPLoop(Kind, nullptr, nullptr, TransformedStmt, SemaRef,
+                        *DSAStack, TmpDSA, LoopHelpers[LoopSeqSize]);
+
+    if (!IsCanonical) {
+      Diag(TransformedStmt->getBeginLoc(), diag::err_omp_not_canonical_loop)
+          << getOpenMPDirectiveName(Kind);
+      return false;
     }
+    StoreLoopStatements(TransformedStmt);
+    updatePreInits(LoopTransform, TransformsPreInits);
+
+    NumLoops += NumGeneratedLoops;
+    ++LoopSeqSize;
+    return true;
   };
 
   /// Modularized code for handling regular canonical loops
@@ -16303,7 +16301,7 @@ StmtResult SemaOpenMP::ActOnOpenMPFuseDirective(ArrayRef<OMPClause *> Clauses,
       // Only TransformSingleLoop requires inserting pre-inits here
 
       if (LoopCategories[I] == OMPLoopCategory::TransformSingleLoop) {
-        auto TransformPreInit = TransformsPreInits[TransformIndex++];
+        const auto &TransformPreInit = TransformsPreInits[TransformIndex++];
         if (!TransformPreInit.empty()) {
           llvm::append_range(PreInits, TransformPreInit);
         }
@@ -17456,15 +17454,13 @@ OMPClause *SemaOpenMP::ActOnOpenMPLoopRangeClause(
   if (CountVal.isInvalid())
     Count = nullptr;
 
-  SmallVector<Expr *, 2> ArgsVec = {First, Count};
-
   // OpenMP [6.0, Restrictions]
   // first + count - 1 must not evaluate to a value greater than the
   // loop sequence length of the associated canonical loop sequence.
   // This check must be performed afterwards due to the delayed
   // parsing and computation of the associated loop sequence
   return OMPLoopRangeClause::Create(getASTContext(), StartLoc, LParenLoc,
-                                    FirstLoc, CountLoc, EndLoc, ArgsVec);
+                                    FirstLoc, CountLoc, EndLoc, First, Count);
 }
 
 OMPClause *SemaOpenMP::ActOnOpenMPAlignClause(Expr *A, SourceLocation StartLoc,