Skip to content

[libc++] Remove a few incorrect _LIBCPP_EXPORTED_FROM_ABI annotations #132602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −16
Open

[libc++] Remove a few incorrect _LIBCPP_EXPORTED_FROM_ABI annotations #132602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion libcxx/docs/DesignDocs/VisibilityMacros.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ Visibility Macros
Mark a symbol as being part of our ABI. This includes functions that are part
of the libc++ library, type information and other symbols. On Windows,
this macro applies `dllimport`/`dllexport` to the symbol, and on other
platforms it gives the symbol default visibility.
platforms it gives the symbol default visibility. This macro should never be
used on class templates. On classes it should only be used if the vtable
should be in the shared library.

**_LIBCPP_OVERRIDABLE_FUNC_VIS**
Mark a symbol as being exported by the libc++ library, but allow it to be
Expand Down
2 changes: 1 addition & 1 deletion libcxx/include/__charconv/from_chars_result.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ _LIBCPP_BEGIN_NAMESPACE_STD

#if _LIBCPP_STD_VER >= 17

struct _LIBCPP_EXPORTED_FROM_ABI from_chars_result {
struct from_chars_result {
const char* ptr;
errc ec;
# if _LIBCPP_STD_VER >= 20
Expand Down
2 changes: 1 addition & 1 deletion libcxx/include/__charconv/to_chars_result.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ _LIBCPP_BEGIN_NAMESPACE_STD

#if _LIBCPP_STD_VER >= 17

struct _LIBCPP_EXPORTED_FROM_ABI to_chars_result {
struct to_chars_result {
char* ptr;
errc ec;
# if _LIBCPP_STD_VER >= 20
Expand Down
2 changes: 1 addition & 1 deletion libcxx/include/__filesystem/file_status.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

_LIBCPP_BEGIN_NAMESPACE_FILESYSTEM

class _LIBCPP_EXPORTED_FROM_ABI file_status {
class file_status {
public:
// constructors
_LIBCPP_HIDE_FROM_ABI file_status() noexcept : file_status(file_type::none) {}
Expand Down
2 changes: 1 addition & 1 deletion libcxx/include/__filesystem/path.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -861,7 +861,7 @@ class _LIBCPP_EXPORTED_FROM_ABI path {
}

// iterators
class _LIBCPP_EXPORTED_FROM_ABI iterator;
class iterator;
typedef iterator const_iterator;

iterator begin() const;
Expand Down
2 changes: 1 addition & 1 deletion libcxx/include/__filesystem/space_info.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

_LIBCPP_BEGIN_NAMESPACE_FILESYSTEM

struct _LIBCPP_EXPORTED_FROM_ABI space_info {
struct space_info {
uintmax_t capacity;
uintmax_t free;
uintmax_t available;
Expand Down
2 changes: 1 addition & 1 deletion libcxx/include/__format/formatter_output.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ _LIBCPP_BEGIN_NAMESPACE_STD

namespace __formatter {

struct _LIBCPP_EXPORTED_FROM_ABI __padding_size_result {
struct __padding_size_result {
size_t __before_;
size_t __after_;
};
Expand Down
2 changes: 1 addition & 1 deletion libcxx/include/__memory_resource/pool_options.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ namespace pmr {

// [mem.res.pool.options]

struct _LIBCPP_EXPORTED_FROM_ABI pool_options {
struct pool_options {
size_t max_blocks_per_chunk = 0;
size_t largest_required_pool_block = 0;
};
Expand Down
6 changes: 3 additions & 3 deletions libcxx/include/__mutex/tag_types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,15 @@

_LIBCPP_BEGIN_NAMESPACE_STD

struct _LIBCPP_EXPORTED_FROM_ABI defer_lock_t {
struct defer_lock_t {
explicit defer_lock_t() = default;
};

struct _LIBCPP_EXPORTED_FROM_ABI try_to_lock_t {
struct try_to_lock_t {
explicit try_to_lock_t() = default;
};

struct _LIBCPP_EXPORTED_FROM_ABI adopt_lock_t {
struct adopt_lock_t {
explicit adopt_lock_t() = default;
};

Expand Down
2 changes: 1 addition & 1 deletion libcxx/include/__new/nothrow_t.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
# include <new.h>
#else
_LIBCPP_BEGIN_UNVERSIONED_NAMESPACE_STD
struct _LIBCPP_EXPORTED_FROM_ABI nothrow_t {
struct nothrow_t {
explicit nothrow_t() = default;
};
extern _LIBCPP_EXPORTED_FROM_ABI const nothrow_t nothrow;
Expand Down
2 changes: 1 addition & 1 deletion libcxx/include/__system_error/error_category.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

_LIBCPP_BEGIN_NAMESPACE_STD

class _LIBCPP_EXPORTED_FROM_ABI error_condition;
class error_condition;
class _LIBCPP_EXPORTED_FROM_ABI error_code;

class _LIBCPP_HIDDEN __do_message;
Expand Down
2 changes: 1 addition & 1 deletion libcxx/include/__thread/id.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
_LIBCPP_BEGIN_NAMESPACE_STD

#if _LIBCPP_HAS_THREADS
class _LIBCPP_EXPORTED_FROM_ABI __thread_id;
class __thread_id;

namespace this_thread {

Expand Down
2 changes: 1 addition & 1 deletion libcxx/include/__tuple/sfinae_helpers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ _LIBCPP_BEGIN_NAMESPACE_STD

#ifndef _LIBCPP_CXX03_LANG

struct _LIBCPP_EXPORTED_FROM_ABI __check_tuple_constructor_fail {
struct __check_tuple_constructor_fail {
static _LIBCPP_HIDE_FROM_ABI constexpr bool __enable_explicit_default() { return false; }
static _LIBCPP_HIDE_FROM_ABI constexpr bool __enable_implicit_default() { return false; }
template <class...>
Expand Down
2 changes: 1 addition & 1 deletion libcxx/include/__utility/in_place.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ _LIBCPP_BEGIN_NAMESPACE_STD

#if _LIBCPP_STD_VER >= 17

struct _LIBCPP_EXPORTED_FROM_ABI in_place_t {
struct in_place_t {
explicit in_place_t() = default;
};
inline constexpr in_place_t in_place{};
Expand Down
Loading