-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[clang][CGObjC] Sign the v-table pointer in ObjC exception RTTI. #135562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
5dc1e5f
fadf7d8
b688c00
6454572
8db3653
252ff4d
86a6d7f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7676,10 +7676,26 @@ CGObjCNonFragileABIMac::GetInterfaceEHType(const ObjCInterfaceDecl *ID, | |
} | ||
|
||
llvm::Value *VTableIdx = llvm::ConstantInt::get(CGM.Int32Ty, 2); | ||
llvm::Constant *VTablePtr = llvm::ConstantExpr::getInBoundsGetElementPtr( | ||
VTableGV->getValueType(), VTableGV, VTableIdx); | ||
|
||
ConstantInitBuilder builder(CGM); | ||
auto values = builder.beginStruct(ObjCTypes.EHTypeTy); | ||
values.add(llvm::ConstantExpr::getInBoundsGetElementPtr( | ||
VTableGV->getValueType(), VTableGV, VTableIdx)); | ||
|
||
if (auto &Schema = | ||
CGM.getCodeGenOpts().PointerAuth.CXXTypeInfoVTablePointer) { | ||
uint32_t discrimination = 0; | ||
if (Schema.hasOtherDiscrimination()) { | ||
assert(Schema.getOtherDiscrimination() == | ||
PointerAuthSchema::Discrimination::Constant); | ||
discrimination = Schema.getConstantDiscrimination(); | ||
} | ||
values.addSignedPointer( | ||
VTablePtr, Schema.getKey(), Schema.isAddressDiscriminated(), | ||
llvm::ConstantInt::get(CGM.IntPtrTy, discrimination)); | ||
|
||
} else { | ||
values.add(VTablePtr); | ||
} | ||
values.add(GetClassName(ClassName)); | ||
values.add(GetClassGlobal(ID, /*metaclass*/ false, NotForDefinition)); | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
// RUN: %clang_cc1 -triple arm64-apple-ios -fptrauth-calls -emit-llvm -fexceptions -fobjc-exceptions -o - %s | FileCheck %s | ||
|
||
__attribute__((objc_root_class)) | ||
@interface Root { | ||
Class isa; | ||
} | ||
@end | ||
|
||
__attribute__((objc_exception)) | ||
@interface A : Root | ||
@end | ||
|
||
@implementation A | ||
@end | ||
|
||
// CHECK: @"OBJC_EHTYPE_$_A" = global {{%.*}} { ptr ptrauth (ptr getelementptr inbounds (ptr, ptr @objc_ehtype_vtable, i32 2), i32 2), |
Uh oh!
There was an error while loading. Please reload this page.