Skip to content

[InstCombine] fix hwasan mistake in "remove dead loads" #145057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025
Merged

[InstCombine] fix hwasan mistake in "remove dead loads" #145057

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02415d5
[InstCombine] fix hwasan mistake in "remove dead loads"
vtjnash Jun 20, 2025
8dd0a3d
Update InstructionCombining.cpp
vtjnash Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3490,8 +3490,8 @@ Instruction *InstCombinerImpl::visitAllocSite(Instruction &MI) {
replaceInstUsesWith(*I, Result);
eraseInstFromFunction(*I);
Users[i] = nullptr; // Skip examining in the next loop.
}
if (auto *MTI = dyn_cast<MemTransferInst>(I)) {
continue;
} else if (auto *MTI = dyn_cast<MemTransferInst>(I)) {
if (KnowInitZero && isRefSet(*Removable)) {
IRBuilderBase::InsertPointGuard Guard(Builder);
Builder.SetInsertPoint(MTI);
Expand Down
Loading