[llvm] simplify and clean-up DemangleConfig.h #149163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@compnerd, @vgvassilev would one of you be willing to merge this patch for me? It is blocking #147564. Thanks! |
compnerd
approved these changes
Jul 22, 2025
This commit creates a library layering violation because Support already depends on Demangle, e.g. Is there another way you can land this commit w/o creating a cycle? |
SquallATF
pushed a commit
to SquallATF/llvm-project
that referenced
this pull request
Jul 23, 2025
## Purpose Simplify `DEMANGLE_` macro definitions in `llvm/Demangle/DemangleConfig.h` for clarity/maintainability. ## Overview * Alias `DEMANGLE_DUMP_METHOD`, `DEMANGLE_FALLTHROUGH`, and `DEMANGLE_UNREACHABLE` macros to their `LLVM_` counterparts defined in `llvm/Support/Compiler.h` * Remove several `DEMANGLE_`-prefixed macros that were only used within `DemangleConfig.h` ## Background * It should be safe for the `Demangle` component library to depend on `Support`, so there is no need for it to maintain copies of macros defined in `llvm/Support/Compiler.h`. * Since the canonical copy `llvm/Demangle/ItaniumDemangle.h` lives under `libcxxabi`, it cannot directly reference the `LLVM_`-prefixed macros so we define `DEMANGLE_`-prefixed aliases. ## Validation * Built llvm-project on Windows with `clang-cl` and MSVC `cl`. * Built llvm-project on Linux with `clang` and `gcc`.
I don't think so, but this change was just cleanup so I will revert it. |
andrurogerz
added a commit
to andrurogerz/llvm-project
that referenced
this pull request
Jul 23, 2025
This reverts commit efbe98d.
rupprecht
pushed a commit
that referenced
this pull request
Jul 23, 2025
Reverts #149163 because it introduced a layering violation. Support depends on Demangle: [llvm-project/llvm/lib/Support/Unix/Signals.inc](https://github.com/llvm/llvm-project/blob/324773e238026c5d4f501213678a89bf411e1509/llvm/lib/Support/Unix/Signals.inc#L38) Line 38 in [324773e](324773e)
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Jul 23, 2025
…50160) Reverts llvm/llvm-project#149163 because it introduced a layering violation. Support depends on Demangle: [llvm-project/llvm/lib/Support/Unix/Signals.inc](https://github.com/llvm/llvm-project/blob/324773e238026c5d4f501213678a89bf411e1509/llvm/lib/Support/Unix/Signals.inc#L38) Line 38 in [324773e](llvm/llvm-project@324773e)
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Jul 28, 2025
## Purpose Simplify `DEMANGLE_` macro definitions in `llvm/Demangle/DemangleConfig.h` for clarity/maintainability. ## Overview * Alias `DEMANGLE_DUMP_METHOD`, `DEMANGLE_FALLTHROUGH`, and `DEMANGLE_UNREACHABLE` macros to their `LLVM_` counterparts defined in `llvm/Support/Compiler.h` * Remove several `DEMANGLE_`-prefixed macros that were only used within `DemangleConfig.h` ## Background * It should be safe for the `Demangle` component library to depend on `Support`, so there is no need for it to maintain copies of macros defined in `llvm/Support/Compiler.h`. * Since the canonical copy `llvm/Demangle/ItaniumDemangle.h` lives under `libcxxabi`, it cannot directly reference the `LLVM_`-prefixed macros so we define `DEMANGLE_`-prefixed aliases. ## Validation * Built llvm-project on Windows with `clang-cl` and MSVC `cl`. * Built llvm-project on Linux with `clang` and `gcc`.
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Jul 28, 2025
Reverts llvm#149163 because it introduced a layering violation. Support depends on Demangle: [llvm-project/llvm/lib/Support/Unix/Signals.inc](https://github.com/llvm/llvm-project/blob/324773e238026c5d4f501213678a89bf411e1509/llvm/lib/Support/Unix/Signals.inc#L38) Line 38 in [324773e](llvm@324773e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Simplify
DEMANGLE_macro definitions inllvm/Demangle/DemangleConfig.hfor clarity/maintainability.Overview
DEMANGLE_DUMP_METHOD,DEMANGLE_FALLTHROUGH, andDEMANGLE_UNREACHABLEmacros to theirLLVM_counterparts defined inllvm/Support/Compiler.hDEMANGLE_-prefixed macros that were only used withinDemangleConfig.hBackground
Demanglecomponent library to depend onSupport, so there is no need for it to maintain copies of macros defined inllvm/Support/Compiler.h.llvm/Demangle/ItaniumDemangle.hlives underlibcxxabi, it cannot directly reference theLLVM_-prefixed macros so we defineDEMANGLE_-prefixed aliases.Validation
clang-cland MSVCcl.clangandgcc.