Skip to content

[offload] Add missing build dependency #149326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions offload/tools/offload-tblgen/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,11 @@ add_tablegen(offload-tblgen OFFLOAD
RecordTypes.hpp
)

# Make sure that C++ headers are available, if libcxx is built at the same
# time. This is important if clang is set to prefer libc++ over libstdc++
if(TARGET cxx-headers)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment for what this dependency is for?

add_dependencies(offload-tblgen cxx-headers)
endif()

set(OFFLOAD_TABLEGEN_EXE "${OFFLOAD_TABLEGEN_EXE}" CACHE INTERNAL "")
set(OFFLOAD_TABLEGEN_TARGET "${OFFLOAD_TABLEGEN_TARGET}" CACHE INTERNAL "")
Loading