[DAG][ARM] computeKnownBitsForTargetNode - add handling for ARMISD VORRIMM\VBICIMM nodes #149494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-backend-arm Author: woruyu (woruyu) ChangesFull diff: https://github.com/llvm/llvm-project/pull/149494.diff 1 Files Affected:
diff --git a/llvm/lib/Target/ARM/ARMISelLowering.cpp b/llvm/lib/Target/ARM/ARMISelLowering.cpp
index fd3b0525c1056..e9ec35fa1dd8c 100644
--- a/llvm/lib/Target/ARM/ARMISelLowering.cpp
+++ b/llvm/lib/Target/ARM/ARMISelLowering.cpp
@@ -20106,6 +20106,31 @@ void ARMTargetLowering::computeKnownBitsForTargetNode(const SDValue Op,
Known = KnownOp0.intersectWith(KnownOp1);
break;
}
+ case ARMISD::VORRIMM: {
+ KnownBits KnownLHS = DAG.computeKnownBits(Op.getOperand(0), Depth + 1);
+
+ unsigned Encoded = Op.getConstantOperandVal(1);
+ unsigned ElemSize = Op.getValueType().getScalarSizeInBits();
+ uint64_t DecodedVal = ARM_AM::decodeVMOVModImm(Encoded, ElemSize);
+ APInt Imm(Known.getBitWidth(), DecodedVal);
+
+ Known.One = KnownLHS.One | Imm;
+ Known.Zero = KnownLHS.Zero & ~Imm;
+ return;
+ }
+ case ARMISD::VBICIMM: {
+ KnownBits KnownLHS = DAG.computeKnownBits(Op.getOperand(0), Depth + 1);
+
+ unsigned Encoded = Op.getConstantOperandVal(1);
+ unsigned ElemSize = Op.getValueType().getScalarSizeInBits();
+ uint64_t DecodedVal = ARM_AM::decodeVMOVModImm(Encoded, ElemSize);
+ APInt Imm(Known.getBitWidth(), DecodedVal);
+
+ APInt NotImm = ~Imm;
+ Known.One = KnownLHS.One & NotImm;
+ Known.Zero = KnownLHS.Zero | Imm;
+ return;
+ }
}
}
|
RKSimon
reviewed
Jul 18, 2025
|
Test coverage? Some of the ARM experts may have some suggestions. |
|
Finding the tests for this is often difficult. Is it worth adding a test like AArch64SelectionDAGTest for them? |
woruyu
force-pushed
the
feat/add-vorrimm-vbicimm-for-computeKnownBitsForTargetNode
branch
3 times, most recently
from
c4942f4 to
e8e0ba2
Compare
RKSimon
reviewed
Aug 15, 2025
davemgreen
reviewed
Aug 16, 2025
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
woruyu
force-pushed
the
feat/add-vorrimm-vbicimm-for-computeKnownBitsForTargetNode
branch
from
a3722f0 to
6882840
Compare
davemgreen
reviewed
Aug 18, 2025
davemgreen
reviewed
Aug 26, 2025
woruyu
force-pushed
the
feat/add-vorrimm-vbicimm-for-computeKnownBitsForTargetNode
branch
from
4f60b47 to
f3b5b90
Compare
RKSimon
reviewed
Aug 29, 2025
…RRIMM\VBICIMM nodes
woruyu
force-pushed
the
feat/add-vorrimm-vbicimm-for-computeKnownBitsForTargetNode
branch
from
f3b5b90 to
a7fbc84
Compare
RKSimon
reviewed
Sep 3, 2025
davemgreen
approved these changes
Sep 4, 2025
Yes, thanks. I’ll land this shortly. |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/190/builds/26690 Here is the relevant piece of the build log for the reference |
I looked into the This isn’t caused by my patch. The builder is hitting an environment issue: |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/76/builds/12646 Here is the relevant piece of the build log for the reference |
|
The clang-ppc64le-linux-multistage failure does look related though - missing Analysis lib dependency: |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/145/builds/9555 Here is the relevant piece of the build log for the reference |
RKSimon
added a commit
that referenced
this pull request
Sep 4, 2025
|
clang-ppc64le-rhel appears to missing LLVMAsmParser |
RKSimon
added a commit
that referenced
this pull request
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves #147179