Skip to content

[libc] Revise document on building exhaustive math functions. #149635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025

Conversation

c8ef
Copy link
Contributor

@c8ef c8ef commented Jul 19, 2025

I suspect the reason is that we use add_fp_unittest in exhaustive testing, so the suffix __unit__ is necessary.

@llvmbot llvmbot added the libc label Jul 19, 2025
@c8ef c8ef requested review from overmighty and lntue July 19, 2025 03:54
@llvmbot
Copy link
Member

llvmbot commented Jul 19, 2025

@llvm/pr-subscribers-libc

Author: Connector Switch (c8ef)

Changes

I suspect the reason is that we use add_fp_unittest in exhaustive testing, so the suffix __unit__ is necessary.


Full diff: https://github.com/llvm/llvm-project/pull/149635.diff

1 Files Affected:

  • (modified) libc/src/math/docs/add_math_function.md (+2-2)
diff --git a/libc/src/math/docs/add_math_function.md b/libc/src/math/docs/add_math_function.md
index daaf1a3ec5639..d2c85ecf7d9b7 100644
--- a/libc/src/math/docs/add_math_function.md
+++ b/libc/src/math/docs/add_math_function.md
@@ -183,8 +183,8 @@ implementation (which is very often glibc).
 
 - Build and Run exhaustive test (might take hours to run):
 ```
-  $ ninja libc.test.src.math.exhaustive.<func>_test
-  $ projects/libc/test/src/math/exhaustive/libc.test.src.math.exhaustive.<func>_test
+  $ ninja libc.test.src.math.exhaustive.<func>_test.__unit__
+  $ projects/libc/test/src/math/exhaustive/libc.test.src.math.exhaustive.<func>_test.__unit__
 ```
 
 - Build and Run performance test:

Copy link
Contributor Author

c8ef commented Jul 21, 2025

Merge activity

  • Jul 21, 12:17 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 21, 12:19 AM UTC: Graphite couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).

@c8ef c8ef merged commit 0bb1e04 into llvm:main Jul 21, 2025
21 checks passed
@c8ef c8ef deleted the add_math branch July 21, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants