-
Notifications
You must be signed in to change notification settings - Fork 14.7k
[compiler-rt][MSVC] Conditionally remove emupac.cpp for msvc #149823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'll go ahead and merge here since this is a low-risk change that should only affect MSVC. |
"MSVC" is true both for msvc and clang-cl. Do you want to exclude this for clang-cl too? (I.e. is this about a cl.exe limitation, or a PE/COFF limitation?) |
@nico thanks, I didn't know they shared that evaluation here! clang-cl uses the MSVC-style inline assembly syntax, I think (?), so this should also apply for it as well. |
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/38935 Here is the relevant piece of the build log for the reference
|
|
My mistake @pcc, I thought the |
Follow up here: #150108 |
Follow up to #149823 to include `clang-cl` for AArch64 builtins sources.
…9823) llvm#148094 introduces logic for emulated PAC, which utilizes language extensions not available on MSVC.
Follow up to llvm#149823 to include `clang-cl` for AArch64 builtins sources.
#148094 introduces logic for emulated PAC, which utilizes language extensions not available on MSVC.