[libc++][hardening] Don't use fputs on Fuchsia.
#150558
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a quick fix for a build error on Fuchsia where many C standard library filesystem-related functions are not available; it effectively makes the hardening log function a no-op on Fuchsia. Links: * llvm#149452 (comment) * https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8708441153070837249/overview
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Konstantin Varlamov (var-const) ChangesThis is a quick fix for a build error on Fuchsia where many C standard Links:
Full diff: https://github.com/llvm/llvm-project/pull/150558.diff 1 Files Affected:
diff --git a/libcxx/src/experimental/log_hardening_failure.cpp b/libcxx/src/experimental/log_hardening_failure.cpp
index f836c15452249..d385c706c8257 100644
--- a/libcxx/src/experimental/log_hardening_failure.cpp
+++ b/libcxx/src/experimental/log_hardening_failure.cpp
@@ -18,7 +18,9 @@ _LIBCPP_BEGIN_NAMESPACE_STD
void __log_hardening_failure(const char* message) noexcept {
// Always log the message to `stderr` in case the platform-specific system calls fail.
+#ifndef __Fuchsia__ // `fputs` is not available on Fuchsia.
std::fputs(message, stderr);
+#endif
#if defined(__BIONIC__)
// Show error in logcat. The latter two arguments are ignored on Android.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix for a build error on Fuchsia where many C standard
library filesystem-related functions are not available; it effectively
makes the hardening log function a no-op on Fuchsia.
Links: