[mlir][tosa] Use typeConverter->convertType<T>

[CoTinker]

Since resultTy might be nullptr, we should use dyn_cast instead of cast. Additionally, typeConverter->convertType<T> is more appropriate in this context.

[llvmbot]

@llvm/pr-subscribers-mlir-linalg
@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-tosa

Author: Longsheng Mou (CoTinker)

Changes

Since resultTy might be nullptr, we should use dyn_cast instead of cast. Additionally, typeConverter->convertType<T> is more appropriate in this context.

---

Full diff: https://github.com/llvm/llvm-project/pull/150578.diff

1 Files Affected:

• (modified) mlir/lib/Conversion/TosaToLinalg/TosaToLinalgNamed.cpp (+1-1)

diff --git a/mlir/lib/Conversion/TosaToLinalg/TosaToLinalgNamed.cpp b/mlir/lib/Conversion/TosaToLinalg/TosaToLinalgNamed.cpp
index 3a205246ddd9e..b7fb7a18c7714 100644
--- a/mlir/lib/Conversion/TosaToLinalg/TosaToLinalgNamed.cpp
+++ b/mlir/lib/Conversion/TosaToLinalg/TosaToLinalgNamed.cpp
@@ -742,7 +742,7 @@ class MaxPool2dConverter : public OpConversionPattern<tosa::MaxPool2dOp> {
 
     bool isUnsigned = op.getType().getElementType().isUnsignedInteger();
     ShapedType resultTy =
-        cast<ShapedType>(getTypeConverter()->convertType(op.getType()));
+        getTypeConverter()->convertType<ShapedType>(op.getType());
     if (!resultTy)
       return rewriter.notifyMatchFailure(op, "failed to convert type");
     Type resultETy = inputTy.getElementType();

[FranklandJack]

Is this really an NFC if we have gone from a static cast to a dynamic one? If not, could we add a test to exercise this change?

[CoTinker]

Is this really an NFC if we have gone from a static cast to a dynamic one? If not, could we add a test to exercise this change?

Yea, you are right. But can't build a test now for that typeConvert not return nullptr.

llvm-project/mlir/lib/Dialect/Tosa/Transforms/TosaTypeConverters.cpp

Lines 20 to 33 in d4f9c11

	void mlir::tosa::populateTosaTypeConversion(TypeConverter &converter) {
	converter.addConversion([&](Type type) -> std::optional<Type> {
	if (type.isUnsignedInteger()) {
	return IntegerType::get(type.getContext(), type.getIntOrFloatBitWidth(),
	IntegerType::SignednessSemantics::Signless);
	}
	return type;
	});
	converter.addConversion([&](TensorType type) -> std::optional<Type> {
	auto converted = converter.convertType(type.getElementType());
	if (!converted)
	return {};
	return type.clone(converted);
	});

[CoTinker]

Hi @lhutton1 , could you please take a look at this PR? thanks.

[lhutton1]

LGTM, thanks!

[CoTinker]

Thanks for your review.