Skip to content

[OpenMP] Fix LLVM_ENABLE_PROJECTS=openmp build #151117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025

Conversation

Meinersbur
Copy link
Member

Set LLVM_TREE_AVAILABLE when not defined after #149871. In particular, the LLVM build tree is obviously available with add_subdirectory(openmp) from the LLVM build tree itself. Note that this build mode is deprecated since #136314.

@Meinersbur Meinersbur requested a review from jprotze July 29, 2025 10:16
@llvmbot llvmbot added openmp:libomp OpenMP host runtime openmp:libomptarget OpenMP offload runtime labels Jul 29, 2025
@Meinersbur Meinersbur requested a review from madhur13490 July 29, 2025 10:16
# See https://github.com/llvm/llvm-project/issues/124014
if (NOT LLVM_RUNTIMES_BUILD AND "openmp" IN_LIST LLVM_ENABLE_PROJECTS)
set(LLVM_TREE_AVAILABLE True)
endif ()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not an expert in build infrastructure of OpenMP in LLVM, but if we say the mode is deprecated, then why should we continue making changes in the code and keep supporting it? Let's update the documents and fully deprecate LLVM_ENABLE_PROJECTS=openmp?

Copy link
Member Author

@Meinersbur Meinersbur Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecation is just a notice that it is going to be removed to encourage users to move away from it. Until it really is removed, is should still work (or why would one keep non-working code around?).

Copy link
Collaborator

@jprotze jprotze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Meinersbur Meinersbur merged commit 9b2b5bf into llvm:main Aug 5, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openmp:libomp OpenMP host runtime openmp:libomptarget OpenMP offload runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants