Skip to content

[LoongArch] Implement isLegalAddressingMode for lsx/lasx #151917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: users/zhaoqi5/test-vec-addressmode
Choose a base branch
from
Draft

[LoongArch] Implement isLegalAddressingMode for lsx/lasx #151917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47ba251
[LoongArch] Implement isLegalAddressingMode for lsx/lasx
zhaoqi5 Jul 28, 2025
ef4d37b
only isint12
zhaoqi5 Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8384,16 +8384,23 @@ bool LoongArchTargetLowering::isLegalAddressingMode(const DataLayout &DL,
// 2. reg + 12-bit signed offset
// 3. reg + 14-bit signed offset left-shifted by 2
// 4. reg1 + reg2
// TODO: Add more checks after support vector extension.
//
// LoongArch LSX/LASX vector extension has three basic addressing modes:
// 1. reg + 12-bit signed offset
// 2. reg + {12/11/10/9}-bit or 8-bit signed offset multiplied by element
// width. ie.
// si8, si8<<1, si8<<2, si8<<3
// si12, si11<<1, si10<<2, si9<<3
// 3. reg1 + reg2

// No global is ever allowed as a base.
if (AM.BaseGV)
return false;

// Require a 12-bit signed offset or 14-bit signed offset left-shifted by 2
// with `UAL` feature.
if (!isInt<12>(AM.BaseOffs) &&
!(isShiftedInt<14, 2>(AM.BaseOffs) && Subtarget.hasUAL()))
if (!isInt<12>(AM.BaseOffs) && !(isShiftedInt<14, 2>(AM.BaseOffs) &&
Subtarget.hasUAL() && !isa<VectorType>(Ty)))
return false;

switch (AM.Scale) {
Expand Down
19 changes: 9 additions & 10 deletions llvm/test/CodeGen/LoongArch/lasx/loop-reduce.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,26 +10,25 @@
define dso_local void @foo() local_unnamed_addr {
; CHECK-LABEL: foo:
; CHECK: # %bb.0: # %entry
; CHECK-NEXT: lu12i.w $a0, -2
; CHECK-NEXT: pcalau12i $a1, %pc_hi20(.LCPI0_0)
; CHECK-NEXT: xvld $xr0, $a1, %pc_lo12(.LCPI0_0)
; CHECK-NEXT: pcalau12i $a1, %pc_hi20(.LCPI0_1)
; CHECK-NEXT: xvld $xr1, $a1, %pc_lo12(.LCPI0_1)
; CHECK-NEXT: pcalau12i $a0, %pc_hi20(.LCPI0_0)
; CHECK-NEXT: xvld $xr0, $a0, %pc_lo12(.LCPI0_0)
; CHECK-NEXT: pcalau12i $a0, %pc_hi20(.LCPI0_1)
; CHECK-NEXT: xvld $xr1, $a0, %pc_lo12(.LCPI0_1)
; CHECK-NEXT: ori $a0, $zero, 1024
; CHECK-NEXT: pcalau12i $a1, %pc_hi20(a)
; CHECK-NEXT: addi.d $a1, $a1, %pc_lo12(a)
; CHECK-NEXT: lu12i.w $a2, 2
; CHECK-NEXT: .p2align 4, , 16
; CHECK-NEXT: .LBB0_1: # %vector.body
; CHECK-NEXT: # =>This Inner Loop Header: Depth=1
; CHECK-NEXT: add.d $a3, $a1, $a0
; CHECK-NEXT: xvldx $xr2, $a3, $a2
; CHECK-NEXT: xvld $xr2, $a1, 0
; CHECK-NEXT: xvpermi.d $xr3, $xr2, 78
; CHECK-NEXT: xvori.b $xr4, $xr0, 0
; CHECK-NEXT: xvshuf.d $xr4, $xr0, $xr3
; CHECK-NEXT: xvori.b $xr3, $xr1, 0
; CHECK-NEXT: xvshuf.w $xr3, $xr4, $xr2
; CHECK-NEXT: addi.d $a0, $a0, 16
; CHECK-NEXT: xvstx $xr3, $a3, $a2
; CHECK-NEXT: xvst $xr3, $a1, 0
; CHECK-NEXT: addi.d $a0, $a0, -2
; CHECK-NEXT: addi.d $a1, $a1, 16
; CHECK-NEXT: bnez $a0, .LBB0_1
; CHECK-NEXT: # %bb.2: # %for.end
; CHECK-NEXT: ret
Expand Down
11 changes: 5 additions & 6 deletions llvm/test/CodeGen/LoongArch/lsx/loop-reduce.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,17 @@
define dso_local void @foo() local_unnamed_addr {
; CHECK-LABEL: foo:
; CHECK: # %bb.0: # %entry
; CHECK-NEXT: lu12i.w $a0, -2
; CHECK-NEXT: ori $a0, $zero, 1024
; CHECK-NEXT: pcalau12i $a1, %pc_hi20(a)
; CHECK-NEXT: addi.d $a1, $a1, %pc_lo12(a)
; CHECK-NEXT: lu12i.w $a2, 2
; CHECK-NEXT: .p2align 4, , 16
; CHECK-NEXT: .LBB0_1: # %vector.body
; CHECK-NEXT: # =>This Inner Loop Header: Depth=1
; CHECK-NEXT: add.d $a3, $a1, $a0
; CHECK-NEXT: vldx $vr0, $a3, $a2
; CHECK-NEXT: vld $vr0, $a1, 0
; CHECK-NEXT: vshuf4i.w $vr0, $vr0, 9
; CHECK-NEXT: addi.d $a0, $a0, 16
; CHECK-NEXT: vstx $vr0, $a3, $a2
; CHECK-NEXT: vst $vr0, $a1, 0
; CHECK-NEXT: addi.d $a0, $a0, -2
; CHECK-NEXT: addi.d $a1, $a1, 16
; CHECK-NEXT: bnez $a0, .LBB0_1
; CHECK-NEXT: # %bb.2: # %for.end
; CHECK-NEXT: ret
Expand Down