-
Notifications
You must be signed in to change notification settings - Fork 15.1k
[LV] Add initial legality checks for loops with unbound loads. #152422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
dc5b7c1
[LV] Add initial legality checks for loops with non-dereferenceable l…
arcbbb 78f05df
Fix braces
arcbbb f5315f8
Limit to single unbound access. Add tests
arcbbb d3246bd
clang-formatted
arcbbb eb316ee
trivial fix: use lower case
arcbbb faa6112
trivial fix
arcbbb b206c9f
Address comment and refine TTI to check data type
arcbbb 72383dd
Query subtarget feature for misaligned access support
arcbbb 0c1d007
Add align 1 case
arcbbb e22c486
Rename isLegalSpeculativeLoad to isLegalFaultOnlyFirstLoad
arcbbb 2a37216
Rename isReadOnlyLoopWithSafeOrSpeculativeLoads to
arcbbb abb0120
Rename SpeculativeLoads to FaultOnlyFirstLoads
arcbbb 6b920f4
Refine comments with ff loads
arcbbb 22dee5b
Update unittest to check the returned instructions
arcbbb e88d5d4
Refine report messages
arcbbb 12e6dc9
Remove TTI isLegalFaultOnlyFirstLoad
arcbbb 3284452
Update tests
arcbbb 10156ca
Refine description
arcbbb 16b5376
Rename isLoopSafeWithLoadOnlyFaults to isReadOnlyLoop
arcbbb 357ff34
Refine error message
arcbbb ead7a78
Refine LoadTest
arcbbb 9e98d12
clang-format
arcbbb f18dae7
Update tests
arcbbb 9dc5a7a
Rename IsLoadOnlyFaultingLoop to IsReadOnlyLoop
arcbbb 380e064
Assert the size of NonDerefLoads
arcbbb 93db706
pass NonDereferenceableAndAlignedLoads as reference
arcbbb 43976f7
Rename FaultOnlyFirstLoads to PotentiallyFaultingLoads
arcbbb 51a8329
Update report message in LoopVectorize
arcbbb 7a99472
Update descriptions
arcbbb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -870,3 +870,19 @@ bool llvm::isDereferenceableReadOnlyLoop( | |
} | ||
return true; | ||
} | ||
|
||
bool llvm::isReadOnlyLoopWithSafeOrSpeculativeLoads( | ||
arcbbb marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
Loop *L, ScalarEvolution *SE, DominatorTree *DT, AssumptionCache *AC, | ||
SmallVectorImpl<LoadInst *> *SpeculativeLoads, | ||
arcbbb marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
SmallVectorImpl<const SCEVPredicate *> *Predicates) { | ||
for (BasicBlock *BB : L->blocks()) { | ||
for (Instruction &I : *BB) { | ||
if (auto *LI = dyn_cast<LoadInst>(&I)) { | ||
if (!isDereferenceableAndAlignedInLoop(LI, L, *SE, *DT, AC, Predicates)) | ||
SpeculativeLoads->push_back(LI); | ||
arcbbb marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
} else if (I.mayReadFromMemory() || I.mayWriteToMemory() || I.mayThrow()) | ||
return false; | ||
|
||
} | ||
} | ||
return true; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.