Skip to content

Conversation

silee2
Copy link
Contributor

@silee2 silee2 commented Aug 13, 2025

Adding missing dependency SPIRVDesc, SPIRVInfo
Fixes post commit build issue with #148286

@llvmbot
Copy link
Member

llvmbot commented Aug 13, 2025

@llvm/pr-subscribers-mlir

Author: Sang Ik Lee (silee2)

Changes

Adding missing dependency SPIRVDesc, SPIRVInfo
Fixes post commit build issue with #148286


Full diff: https://github.com/llvm/llvm-project/pull/153505.diff

1 Files Affected:

  • (modified) mlir/lib/Target/LLVM/CMakeLists.txt (+2-1)
diff --git a/mlir/lib/Target/LLVM/CMakeLists.txt b/mlir/lib/Target/LLVM/CMakeLists.txt
index d3a8f3c02599f..9a0e4d45693b8 100644
--- a/mlir/lib/Target/LLVM/CMakeLists.txt
+++ b/mlir/lib/Target/LLVM/CMakeLists.txt
@@ -213,7 +213,8 @@ endif()
 if ("SPIRV" IN_LIST LLVM_TARGETS_TO_BUILD)
   set(SPIRV_LIBS
     SPIRVCodeGen
-
+    SPIRVDesc
+    SPIRVInfo
   )
 endif()
 

@llvmbot
Copy link
Member

llvmbot commented Aug 13, 2025

@llvm/pr-subscribers-mlir-llvm

Author: Sang Ik Lee (silee2)

Changes

Adding missing dependency SPIRVDesc, SPIRVInfo
Fixes post commit build issue with #148286


Full diff: https://github.com/llvm/llvm-project/pull/153505.diff

1 Files Affected:

  • (modified) mlir/lib/Target/LLVM/CMakeLists.txt (+2-1)
diff --git a/mlir/lib/Target/LLVM/CMakeLists.txt b/mlir/lib/Target/LLVM/CMakeLists.txt
index d3a8f3c02599f..9a0e4d45693b8 100644
--- a/mlir/lib/Target/LLVM/CMakeLists.txt
+++ b/mlir/lib/Target/LLVM/CMakeLists.txt
@@ -213,7 +213,8 @@ endif()
 if ("SPIRV" IN_LIST LLVM_TARGETS_TO_BUILD)
   set(SPIRV_LIBS
     SPIRVCodeGen
-
+    SPIRVDesc
+    SPIRVInfo
   )
 endif()
 

Copy link
Contributor

@nbpatel nbpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silee2 silee2 merged commit 9f953fa into llvm:main Aug 13, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants