[LifetimeSafety] Track gsl::Pointer types

[usx95]

Add support for GSL pointer types in lifetime safety analysis, enabling detection of dangling references in pointer-like types.

[usx95]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• [LifetimeSafety] Track gsl::Pointer types #154009 👈 (View in Graphite)
• Add decl/expr name to Origin's debug output #153951
• [LifetimeSafety] Prevent duplicate loans and statement visits #153661 : 1 other dependent PR (#153669 )
• [LifetimeSafety] Implement a basic use-after-free diagnostic #149731
• [LifetimeSafety] Add loan expiry analysis #148712 : 1 other dependent PR (#148976 )
• [LifetimeSafety] Revamp test suite using unittests #149158
• [LifetimeSafety] Add per-program-point lattice tracking #149199
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:

git-clang-format --diff HEAD~1 HEAD --extensions cpp -- clang/lib/Analysis/LifetimeSafety.cpp clang/unittests/Analysis/LifetimeSafetyTest.cpp

View the diff from clang-format here.

diff --git a/clang/unittests/Analysis/LifetimeSafetyTest.cpp b/clang/unittests/Analysis/LifetimeSafetyTest.cpp
index b339adf69..89c3b9c41 100644
--- a/clang/unittests/Analysis/LifetimeSafetyTest.cpp
+++ b/clang/unittests/Analysis/LifetimeSafetyTest.cpp
@@ -888,7 +888,9 @@ TEST_F(LifetimeAnalysisTest, GslPointerReassignment) {
 
   EXPECT_THAT(Origin("v"), HasLoansTo({"safe"}, "p1"));
   EXPECT_THAT(Origin("v"), HasLoansTo({"unsafe"}, "p2"));
-  EXPECT_THAT(Origin("v"), HasLoansTo({"unsafe"}, "p3")); // The loan is still held, just expired.
+  EXPECT_THAT(
+      Origin("v"),
+      HasLoansTo({"unsafe"}, "p3")); // The loan is still held, just expired.
   EXPECT_THAT(LoansTo({"unsafe"}), AreExpiredAt("p3"));
 }