[MLIR][DialectConversion] Export isOpIgnored in ConversionPatternRewriter

[wsmoses]

This is particularly helpful for more complex dialect conversion patterns which conditionally apply given the subject of an analysis of the non-deleted operations

[llvmbot]

@llvm/pr-subscribers-mlir

Author: William Moses (wsmoses)

Changes

This is particularly helpful for more complex dialect conversion patterns which conditionally apply given the subject of an analysis of the non-deleted operations

---

Full diff: https://github.com/llvm/llvm-project/pull/154300.diff

2 Files Affected:

• (modified) mlir/include/mlir/Transforms/DialectConversion.h (+3)
• (modified) mlir/lib/Transforms/Utils/DialectConversion.cpp (+4)

diff --git a/mlir/include/mlir/Transforms/DialectConversion.h b/mlir/include/mlir/Transforms/DialectConversion.h
index 536b23f5c33c1..5de58b89130a2 100644
--- a/mlir/include/mlir/Transforms/DialectConversion.h
+++ b/mlir/include/mlir/Transforms/DialectConversion.h
@@ -862,6 +862,9 @@ class ConversionPatternRewriter final : public PatternRewriter {
   /// Return a reference to the internal implementation.
   detail::ConversionPatternRewriterImpl &getImpl();
 
+  /// Return "true" if the given operation was replaced or erased.
+  bool isOpIgnored(Operation *op) const;
+
 private:
   // Allow OperationConverter to construct new rewriters.
   friend struct OperationConverter;
diff --git a/mlir/lib/Transforms/Utils/DialectConversion.cpp b/mlir/lib/Transforms/Utils/DialectConversion.cpp
index 7494ca9ec3784..f95340c718409 100644
--- a/mlir/lib/Transforms/Utils/DialectConversion.cpp
+++ b/mlir/lib/Transforms/Utils/DialectConversion.cpp
@@ -2245,6 +2245,10 @@ detail::ConversionPatternRewriterImpl &ConversionPatternRewriter::getImpl() {
   return *impl;
 }
 
+bool ConversionPatternRewriter::isOpIgnored(Operation *op) const {
+  return getImpl()->isOpIgnored(op);
+}
+
 //===----------------------------------------------------------------------===//
 // ConversionPattern
 //===----------------------------------------------------------------------===//

[llvmbot]

@llvm/pr-subscribers-mlir-core

Author: William Moses (wsmoses)

Changes

This is particularly helpful for more complex dialect conversion patterns which conditionally apply given the subject of an analysis of the non-deleted operations

---

Full diff: https://github.com/llvm/llvm-project/pull/154300.diff

2 Files Affected:

• (modified) mlir/include/mlir/Transforms/DialectConversion.h (+3)
• (modified) mlir/lib/Transforms/Utils/DialectConversion.cpp (+4)

diff --git a/mlir/include/mlir/Transforms/DialectConversion.h b/mlir/include/mlir/Transforms/DialectConversion.h
index 536b23f5c33c1..5de58b89130a2 100644
--- a/mlir/include/mlir/Transforms/DialectConversion.h
+++ b/mlir/include/mlir/Transforms/DialectConversion.h
@@ -862,6 +862,9 @@ class ConversionPatternRewriter final : public PatternRewriter {
   /// Return a reference to the internal implementation.
   detail::ConversionPatternRewriterImpl &getImpl();
 
+  /// Return "true" if the given operation was replaced or erased.
+  bool isOpIgnored(Operation *op) const;
+
 private:
   // Allow OperationConverter to construct new rewriters.
   friend struct OperationConverter;
diff --git a/mlir/lib/Transforms/Utils/DialectConversion.cpp b/mlir/lib/Transforms/Utils/DialectConversion.cpp
index 7494ca9ec3784..f95340c718409 100644
--- a/mlir/lib/Transforms/Utils/DialectConversion.cpp
+++ b/mlir/lib/Transforms/Utils/DialectConversion.cpp
@@ -2245,6 +2245,10 @@ detail::ConversionPatternRewriterImpl &ConversionPatternRewriter::getImpl() {
   return *impl;
 }
 
+bool ConversionPatternRewriter::isOpIgnored(Operation *op) const {
+  return getImpl()->isOpIgnored(op);
+}
+
 //===----------------------------------------------------------------------===//
 // ConversionPattern
 //===----------------------------------------------------------------------===//

[joker-eph]

Can you write a test upstream?

I don't quite get the usage of this right now.

[matthias-springer]

Can you describe a bit when this function is useful? This is an implementation detail of the conversion driver and we should expose it only if needed. (E.g., "ignoredOps" in the new conversion driver (allowPatternRollback = false) has a slightly different meaning because ops are immediately erased.)

Can you work with ConversionTarget::isLegal(Operation *) instead?