Skip to content

[mlir][linalg][nfc] use llvm::DenseMap #154981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

elamc-2
Copy link

@elamc-2 elamc-2 commented Aug 22, 2025

This change swaps std::map for its LLVM equivalent type.

Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot
Copy link
Member

llvmbot commented Aug 22, 2025

@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-linalg

Author: Elam Cohavi (elamc-2)

Changes

This change swaps std::map for its LLVM equivalent type.


Full diff: https://github.com/llvm/llvm-project/pull/154981.diff

1 Files Affected:

  • (modified) mlir/lib/Dialect/Linalg/Transforms/DecomposeGenericByUnfoldingPermutation.cpp (+1-2)
diff --git a/mlir/lib/Dialect/Linalg/Transforms/DecomposeGenericByUnfoldingPermutation.cpp b/mlir/lib/Dialect/Linalg/Transforms/DecomposeGenericByUnfoldingPermutation.cpp
index b7da20c108f3e..9b5c14887b253 100644
--- a/mlir/lib/Dialect/Linalg/Transforms/DecomposeGenericByUnfoldingPermutation.cpp
+++ b/mlir/lib/Dialect/Linalg/Transforms/DecomposeGenericByUnfoldingPermutation.cpp
@@ -8,7 +8,6 @@
 //
 #include "mlir/Dialect/Linalg/IR/Linalg.h"
 #include "mlir/Dialect/Linalg/Transforms/Transforms.h"
-#include <map>
 #include <utility>
 
 using namespace mlir;
@@ -125,7 +124,7 @@ computeTransposeBroadcast(AffineMap &map) {
     // refering to d3, d4. Therefore, re-base the transpose dimensions so
     // that they start from d0.
     permutation.resize(minorSize);
-    std::map<int64_t, int64_t> minorMap;
+    llvm::DenseMap<int64_t, int64_t> minorMap;
     for (int64_t i = 0; i < minorSize; ++i)
       minorMap.insert({sortedResMap[i], i});
 

@@ -125,7 +124,7 @@ computeTransposeBroadcast(AffineMap &map) {
// refering to d3, d4. Therefore, re-base the transpose dimensions so
// that they start from d0.
permutation.resize(minorSize);
std::map<int64_t, int64_t> minorMap;
llvm::DenseMap<int64_t, int64_t> minorMap;
Copy link
Collaborator

@joker-eph joker-eph Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to me that this is all a map of positions right? So why can't we use a SmallVector<int> here?
I think something like:

Suggested change
llvm::DenseMap<int64_t, int64_t> minorMap;
llvm::DenseMap<int> minorMap;
minorMap.resize(map.getNumResults());

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants