Skip to content

[alpha.webkit.UncheckedCallArgsChecker] Don't emit a warning for passing a temporary object as an argument. #155033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

[alpha.webkit.UncheckedCallArgsChecker] Don't emit a warning for passing a temporary object as an argument. #155033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,8 @@ bool isASafeCallArg(const Expr *E) {
return true;
}
}
if (isa<CXXTemporaryObjectExpr>(E))
return true; // A temporary lives until the end of this statement.
if (isConstOwnerPtrMemberExpr(E))
return true;

Expand Down
5 changes: 5 additions & 0 deletions clang/test/Analysis/Checkers/WebKit/unchecked-call-arg.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,8 @@ void foo() {
provide()->doWork();
// expected-warning@-1{{Call argument for 'this' parameter is unchecked and unsafe}}
}

void doWorkWithObject(const CheckedObject&);
void bar() {
doWorkWithObject(CheckedObject());
}