Skip to content

[WebKit checkers] Treat asm brk as trivial #155046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+26 −0
Open

[WebKit checkers] Treat asm brk as trivial #155046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d3e26d
[WebKit checkers] Treat asm brk as trivial
rniwa Aug 22, 2025
f222293
Update the PR for the latest main
rniwa Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,6 +666,10 @@ class TrivialFunctionAnalysisVisitor
return IsFunctionTrivial(Callee);
}

bool VisitGCCAsmStmt(const GCCAsmStmt *AS) {
return AS->getAsmString() == "brk #0xc471";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to be restricted to a specific brk constant, and should it include int3, and similar?

I guess it's unlikely as whitespace is usually present only in multiline asm but is it worth considering stripping white space?

}

bool
VisitSubstNonTypeTemplateParmExpr(const SubstNonTypeTemplateParmExpr *E) {
// Non-type template paramter is compile time constant and trivial.
Expand Down
22 changes: 22 additions & 0 deletions clang/test/Analysis/Checkers/WebKit/trivial-code-check-asm-brk.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
// RUN: %clang_analyze_cc1 -triple arm-darwin -analyzer-checker=alpha.webkit.UncountedCallArgsChecker -verify %s
// expected-no-diagnostics

void crash()
{
__asm__ volatile ("brk #0xc471");
__builtin_unreachable();
}

class SomeObj {
public:
void ref();
void deref();

void someWork() { crash(); }
};

SomeObj* provide();

void doSomeWork() {
provide()->someWork();
}