- 
                Notifications
    You must be signed in to change notification settings 
- Fork 15k
          [libc++][functional] Implement std::bind_front<NTTP>
          #165096
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            JMazurkiewicz
  wants to merge
  7
  commits into
  llvm:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
JMazurkiewicz:libcxx/bind_front_nttp
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
      
        
          +538
        
        
          −0
        
        
          
        
      
    
  
  
     Open
                    Changes from 2 commits
      Commits
    
    
            Show all changes
          
          
            7 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      44e4880
              
                [libc++][functional] Implement `bind_front<NTTP>`
              
              
                JMazurkiewicz 0a0f2e2
              
                [libc++][functional] Test `bind_front<NTTP>`
              
              
                JMazurkiewicz 6d965f9
              
                Remove unnecessary `{}`
              
              
                JMazurkiewicz cb45215
              
                Fix `bind_front.nttp.verify.cpp` test
              
              
                JMazurkiewicz 4cfab17
              
                Use explicit `this` parameter instead of `__perfect_forward` base class
              
              
                JMazurkiewicz 328e808
              
                Return different* function object when `sizeof...(_BoundArgs) == 0`
              
              
                JMazurkiewicz 4f8d61f
              
                Merge remote-tracking branch 'upstream/main' into libcxx/bind_front_nttp
              
              
                JMazurkiewicz File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
|  | @@ -17,6 +17,8 @@ | |
| #include <__type_traits/decay.h> | ||
| #include <__type_traits/enable_if.h> | ||
| #include <__type_traits/is_constructible.h> | ||
| #include <__type_traits/is_member_pointer.h> | ||
| #include <__type_traits/is_pointer.h> | ||
| #include <__utility/forward.h> | ||
|  | ||
| #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) | ||
|  | @@ -49,6 +51,38 @@ _LIBCPP_HIDE_FROM_ABI constexpr auto bind_front(_Fn&& __f, _Args&&... __args) { | |
|  | ||
| #endif // _LIBCPP_STD_VER >= 20 | ||
|  | ||
| #if _LIBCPP_STD_VER >= 26 | ||
|  | ||
| template <auto _Fn> | ||
| struct __nttp_bind_front_op { | ||
| template <class... _Args> | ||
| _LIBCPP_HIDE_FROM_ABI constexpr auto operator()(_Args&&... __args) const | ||
| noexcept(noexcept(std::invoke(_Fn, std::forward<_Args>(__args)...))) | ||
| -> decltype(std::invoke(_Fn, std::forward<_Args>(__args)...)) { | ||
| return std::invoke(_Fn, std::forward<_Args>(__args)...); | ||
| } | ||
| }; | ||
|  | ||
| template <auto _Fn, class... _BoundArgs> | ||
| struct __nttp_bind_front_t : __perfect_forward<__nttp_bind_front_op<_Fn>, _BoundArgs...> { | ||
| using __perfect_forward<__nttp_bind_front_op<_Fn>, _BoundArgs...>::__perfect_forward; | ||
| }; | ||
|  | ||
| template <auto _Fn, class... _Args> | ||
| [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr auto bind_front(_Args&&... __args) { | ||
| static_assert((is_constructible_v<decay_t<_Args>, _Args> && ...), | ||
| "bind_front requires all decay_t<Args> to be constructible from respective Args"); | ||
| static_assert((is_move_constructible_v<decay_t<_Args>> && ...), | ||
| "bind_front requires all decay_t<Args> to be move constructible"); | ||
| if constexpr (using _Ty = decltype(_Fn); is_pointer_v<_Ty> || is_member_pointer_v<_Ty>) { | ||
| static_assert(_Fn != nullptr, "f cannot be equal to nullptr"); | ||
| } | ||
|  | ||
| return __nttp_bind_front_t<_Fn, decay_t<_Args>...>(std::forward<_Args>(__args)...); | ||
|          | ||
| } | ||
|  | ||
| #endif // _LIBCPP_STD_VER >= 26 | ||
|  | ||
| _LIBCPP_END_NAMESPACE_STD | ||
|  | ||
| #endif // _LIBCPP___FUNCTIONAL_BIND_FRONT_H | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
        
          
  
    
      
          
            19 changes: 19 additions & 0 deletions
          
          19 
        
  .../libcxx/utilities/function.objects/func.bind.partial/bind_front.nttp.nodiscard.verify.cpp
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|  | ||
| // REQUIRES: std-at-least-c++26 | ||
|  | ||
| // <functional> | ||
|  | ||
| // Test the libc++ extension that std::bind_front<NTTP> is marked as [[nodiscard]]. | ||
|  | ||
| #include <functional> | ||
|  | ||
| void test() { | ||
| std::bind_front<test>(); // expected-warning {{ignoring return value of function declared with 'nodiscard' attribute}} | ||
| } | 
      
      Oops, something went wrong.
        
    
  
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to use explicit
thisparameters.