Skip to content

[ADT] Simplify control flow in ImmutableSet (NFC) #165133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2025
Merged

[ADT] Simplify control flow in ImmutableSet (NFC) #165133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions llvm/include/llvm/ADT/ImmutableSet.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,9 +635,7 @@ class ImutAVLFactory {
// if find a collision compare those trees by their contents.
unsigned digest = TNew->computeDigest();
TreeTy *&entry = Cache[maskCacheIndex(digest)];
do {
if (!entry)
break;
if (entry) {
for (TreeTy *T = entry ; T != nullptr; T = T->next) {
// Compare the Contents('T') with Contents('TNew')
typename TreeTy::iterator TI = T->begin(), TE = T->end();
Expand All @@ -653,7 +651,6 @@ class ImutAVLFactory {
entry->prev = TNew;
TNew->next = entry;
}
while (false);

entry = TNew;
TNew->IsCanonicalized = true;
Expand Down