Un-XFAIL test now that llvm/llvm-project#144580 is resolved #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is now passing.
s-perron
approved these changes
Jul 8, 2025
spall
approved these changes
Jul 8, 2025
s-perron
requested changes
Jul 11, 2025
There was a problem hiding this comment.
I don't think we can enable this test yet. The problem is that the Intel driver does not support storage images with unknown format. Note that the test will pass if you use a driver that supports this feature, which make the XFAIL awkward.
I need to change the clang compiler to match DXC, and guess at the format. I just opened llvm/llvm-project#148270 to fix this issue.
Updated the XFAIL to just intel since it does pass on other drivers |
s-perron
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test no longer fails because of the original issue, but still has issues
on intel drivers due to llvm/llvm-project#148270