Skip to content

Enable most of the cbuffer tests for clang #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable most of the cbuffer tests for clang #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/Feature/CBuffer/arrays-16bit.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ DescriptorSets:
# DXC's vulkan support does not layout cbuffers compatibly with DXIL
# UNSUPPORTED: Vulkan

# https://github.com/llvm/llvm-project/issues/110722
# XFAIL: Clang
# https://github.com/llvm/llvm-project/issues/138996
# UNSUPPORTED: Clang

# RUN: split-file %s %t
# RUN: %dxc_target -enable-16bit-types -T cs_6_5 -Fo %t.o %t/source.hlsl
Expand Down
2 changes: 1 addition & 1 deletion test/Feature/CBuffer/lit.local.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
if 'Clang' in config.available_features:
if 'Clang-Vulkan' in config.available_features:
config.unsupported = True

# CBuffer bindings seem to be broken under metal
Expand Down
4 changes: 4 additions & 0 deletions test/Feature/CBuffer/structs.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,10 @@ DescriptorSets:
# DXC's vulkan support does not layout cbuffers compatibly with DXIL
# UNSUPPORTED: Vulkan

+# Clang trips on 2-element vectors in structs:
+# https://github.com/llvm/llvm-project/issues/123968
+# UNSUPPORTED: Clang

# RUN: split-file %s %t
# RUN: %dxc_target -T cs_6_5 -Fo %t.o %t/source.hlsl
# RUN: %offloader %t/pipeline.yaml %t.o | FileCheck %s
Expand Down
4 changes: 4 additions & 0 deletions test/Feature/CBuffer/vectors-64bit.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ DescriptorSets:
# DXC's vulkan support does not layout cbuffers compatibly with DXIL
# UNSUPPORTED: Vulkan

# Clang trips on 3-element vectors in structs:
# https://github.com/llvm/llvm-project/issues/123968
# UNSUPPORTED: Clang

# RUN: split-file %s %t
# RUN: %dxc_target -T cs_6_5 -Fo %t.o %t/source.hlsl
# RUN: %offloader %t/pipeline.yaml %t.o | FileCheck %s
Expand Down
4 changes: 4 additions & 0 deletions test/Feature/CBuffer/vectors.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ DescriptorSets:
# DXC's vulkan support does not layout cbuffers compatibly with DXIL
# UNSUPPORTED: Vulkan

# Clang trips on 3-element vectors in structs:
# https://github.com/llvm/llvm-project/issues/123968
# UNSUPPORTED: Clang

# RUN: split-file %s %t
# RUN: %dxc_target -T cs_6_5 -Fo %t.o %t/source.hlsl
# RUN: %offloader %t/pipeline.yaml %t.o | FileCheck %s
Expand Down
Loading