Skip to content

Add AddUint64 tests #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add AddUint64 tests #290

wants to merge 3 commits into from
+70 −0

Conversation

kmpeng
Copy link
Contributor

@kmpeng kmpeng commented Jul 17, 2025

Closes #109.

Adds a test for AddUint64 testing UInt32 type. Values pulled from HLK tests.
Need to remove XFAIL after #149345 is fixed.

bob80905
bob80905 reviewed Jul 17, 2025
View reviewed changes
Copy link
Contributor

@bob80905 bob80905 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to, instead, test an overflow case with a constant-folding variant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bob80905 bob80905 bob80905 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test for AddUint64
2 participants
@kmpeng @bob80905