Skip to content

Conversation

Kothy
Copy link
Contributor

@Kothy Kothy commented Jul 23, 2025

No description provided.

@github-actions github-actions bot added the feature New feature or request label Jul 23, 2025
@Kothy Kothy force-pushed the feature/BORG-562-adds-support-for-eslint-v9 branch 2 times, most recently from 24e2624 to 3854a40 Compare July 24, 2025 06:44
@Kothy Kothy marked this pull request as ready for review July 24, 2025 07:26
@Kothy Kothy requested review from literat and a team as code owners July 24, 2025 07:26
Copy link
Contributor

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thank you for your PR and introducing the migration to ESLint v9.

Now to the review and firstly to commits.

Multiple changes are not atomically separated into the commits.

For example:

  • there is a modification of the workflow that should be in a separate commit
  • there is an update of the prettier dependency + modification of other packages, which should be in a separate commit
  • there are changes in 3 packages, each should be committed with its scope (should be enforced by commitlint 🤔)

Secondly, the API/structure.

I prefer to clean and extend the configs. For example:

  • @lmc-eu/esling-config-base/flat
  • @lmc-eu/esling-config-base/flat/optional
  • etc...

Keep in mind that these are the features, because you are only adding a new config.

Thirdly, the breaking changes and back-compatible changes.

Some changes, like changing the Node.js version, are breaking.
However, you are adding support for flat config as a feature, so I am not sure how this will work together.

I have no problem with these two scenarios:

  1. we are replacing legacy config with the flat one, thus it is ok replace the content of the files and change the Node.js version
  2. we are adding flat config as a feature, thus it should not be breaking, and when I upgrade, everything should work as before

I have not checked the files themselves. These are the main architectural problems I see here. Please, address them first. I should be able to assist.

@Kothy Kothy force-pushed the feature/BORG-562-adds-support-for-eslint-v9 branch 4 times, most recently from 9762280 to d20980e Compare July 30, 2025 07:33
@literat
Copy link
Contributor

literat commented Jul 30, 2025

There are places where you are allowing Node.js version 16, 18, 20, and somewhere only 20. Shouldn't it be the same everywhere?

@Kothy
Copy link
Contributor Author

Kothy commented Jul 31, 2025

There are places where you are allowing Node.js version 16, 18, 20, and somewhere only 20. Shouldn't it be the same everywhere?

I am not sure if I should mess with all the packages, but if you want to increase node version I will do it

@Kothy
Copy link
Contributor Author

Kothy commented Jul 31, 2025

After all changes and fixes are done, I will prettify commits

@Kothy Kothy marked this pull request as draft July 31, 2025 10:52
@literat
Copy link
Contributor

literat commented Aug 1, 2025

Could you please reference this issue #191 in the commits?

@Kothy Kothy force-pushed the feature/BORG-562-adds-support-for-eslint-v9 branch 2 times, most recently from 8abf7ee to f901a20 Compare August 10, 2025 07:12
@Kothy Kothy force-pushed the feature/BORG-562-adds-support-for-eslint-v9 branch 4 times, most recently from befa9a9 to 43e6a14 Compare August 11, 2025 14:40
@Kothy Kothy force-pushed the feature/BORG-562-adds-support-for-eslint-v9 branch from 43e6a14 to b2d7d13 Compare August 11, 2025 15:04
@Kothy Kothy marked this pull request as ready for review August 11, 2025 15:18
Copy link
Contributor

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👏 Thanks for moving this library forward and resolving this big step. I do not see anything that should be addressed now.

I think this is ready to be merged. After that, I will publish the prerelease, and we can test it anywhere we want. Thanks a lot :-)

@Kothy Kothy merged commit 7f4e651 into main Aug 12, 2025
3 checks passed
@Kothy Kothy deleted the feature/BORG-562-adds-support-for-eslint-v9 branch August 12, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants