Switch Carbon from Classic to Cover format #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added .ruby-version (2.7.8) and .bundle/config to specify Ruby version and bundle path. Updated _config.yml to exclude 'vendor' and '.bundle' directories. Updated Gemfile.lock and package-lock.json to reflect dependency and platform changes.
Updated the Carbon Ads script URL and placement logic to match new ad parameters and layout. Simplified Carbon Ads CSS and adjusted SCSS imports for maintainability. The ad script is now inserted after the second child in the docs container, with a fallback to the top if the target is not found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<div>in content to prevent layout shift and maintain ad visibility (better support for Carbon Cover width)The positive tradeoff as we don't have ads in the TOC anymore, although the ad performance may be affected.