Skip to content

[DO NOT MERGE] test: all tests are passing because of empty model discovery #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[DO NOT MERGE] test: all tests are passing because of empty model discovery #609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fdf177
test: all tests are passing because of empty model discovery
aaqilniz Sep 1, 2024
4872c38
test: cover when an empty array of models is returned
aaqilniz Sep 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"scripts": {
"pretest": "node pretest.js",
"lint": "eslint .",
"test": "mocha test/*.test.js",
"test": "mocha test/mysql.discover.test.js",
"posttest": "npm run lint",
"postinstall": "patch-package"
},
Expand Down
9 changes: 9 additions & 0 deletions test/mysql.discover.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ describe('Discover models including other users', function() {
done(err);
} else {
let others = false;
assert(models.length > 0, 'some models returned');
models.find(function(m) {
assert(m.owner);
if (m.owner !== 'STRONGLOOP') {
Expand Down Expand Up @@ -143,6 +144,7 @@ describe('Discover model properties', function() {
console.error(err);
done(err);
} else {
assert(models.length > 0, 'some models returned');
models.forEach(function(m) { productProperties.push(m.columnName); });
productProperties.forEach((prop, index) => {
assert(productPropertiesInOrdinalOrder[index] === prop);
Expand All @@ -159,6 +161,7 @@ describe('Discover model properties', function() {
console.error(err);
done(err);
} else {
assert(models.length > 0, 'some models returned');
models.forEach(function(m) {
assert(m.tableName.toLowerCase() === 'product');
});
Expand All @@ -176,6 +179,7 @@ describe('Discover model primary keys', function() {
console.error(err);
done(err);
} else {
assert(models.length > 0, 'some models returned');
models.forEach(function(m) {
assert(m.tableName.toLowerCase() === 'product');
});
Expand All @@ -190,6 +194,7 @@ describe('Discover model primary keys', function() {
console.error(err);
done(err);
} else {
assert(models.length > 0, 'some models returned');
models.forEach(function(m) {
assert(m.tableName.toLowerCase() === 'product');
});
Expand All @@ -206,6 +211,7 @@ describe('Discover model foreign keys', function() {
console.error(err);
done(err);
} else {
assert(models.length > 0, 'some models returned');
models.forEach(function(m) {
assert(m.fkTableName === 'INVENTORY');
});
Expand All @@ -219,6 +225,7 @@ describe('Discover model foreign keys', function() {
console.error(err);
done(err);
} else {
assert(models.length > 0, 'some models returned');
models.forEach(function(m) {
assert(m.fkTableName === 'INVENTORY');
});
Expand All @@ -232,6 +239,7 @@ describe('Discover model generated columns', function() {
it('should return an array of columns for STRONGLOOP.PRODUCT and none of them is generated', function(done) {
db.discoverModelProperties('product', function(err, models) {
if (err) return done(err);
assert(models.length > 0, 'some models returned');
models.forEach(function(model) {
assert(model.tableName.toLowerCase() === 'product');
assert(!model.generated, 'STRONGLOOP.PRODUCT table should not have generated (identity) columns');
Expand All @@ -242,6 +250,7 @@ describe('Discover model generated columns', function() {
it('should return an array of columns for STRONGLOOP.TESTGEN and the first is generated', function(done) {
db.discoverModelProperties('testgen', function(err, models) {
if (err) return done(err);
assert(models.length > 0, 'some models returned');
models.forEach(function(model) {
assert(model.tableName.toLowerCase() === 'testgen');
if (model.columnName === 'ID') {
Expand Down
Loading