Skip to content

[dv/push_pull] Make sure that ack_o is always reset #28812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2025
+16 −4
Merged

[dv/push_pull] Make sure that ack_o is always reset #28812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions hw/dv/sv/push_pull_agent/push_pull_driver_lib.sv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,10 @@ class push_host_driver #(
`CB.valid_int <= 1'b0;
if (!cfg.hold_h_data_until_next_req) `CB.h_data_int <= 'x;,
wait (cfg.in_reset);)
// In case there is race condition between the logic above and reset_signals task.
// We always set the valid_int again to 0 to make sure the data comes out of reset is not
// valid.
if (cfg.in_reset) `CB.valid_int <= '0;
// In case there is a race condition between the logic above and the reset_signals task, we make
// sure that the reset also de-asserts the valid signal. It can otherwise get stuck high during
// reset and erroneously flag data as valid upon exiting reset.
if (cfg.in_reset) `CB.valid_int <= 1'b0;
endtask

`undef CB
Expand Down Expand Up @@ -179,6 +179,10 @@ class pull_host_driver #(
end
if (!cfg.hold_h_data_until_next_req) `CB.h_data_int <= 'x;,
wait (cfg.in_reset);)
// In case there is a race condition between the logic above and the reset_signals task, we make
// sure that the reset also de-asserts the request signal. It can otherwise get stuck high
// during reset and emit an erroneous request upon exiting reset.
if (cfg.in_reset) `CB.req_int <= 1'b0;
endtask

`undef CB
Expand Down Expand Up @@ -216,6 +220,10 @@ class push_device_driver #(
`CB.ready_int <= 1'b0;
if (!cfg.hold_d_data_until_next_req) `CB.d_data_int <= 'x;,
wait (cfg.in_reset);)
// In case there is a race condition between the logic above and the reset_signals task, we make
// sure that the reset also de-asserts the ready signal. It can otherwise get stuck high during
// reset and erroneously accept data upon exiting reset.
if (cfg.in_reset) `CB.ready_int <= 1'b0;
endtask

`undef CB
Expand Down Expand Up @@ -258,6 +266,10 @@ class pull_device_driver #(
`CB.ack_int <= 1'b0;
if (!cfg.hold_d_data_until_next_req) `CB.d_data_int <= 'x;,
wait (cfg.in_reset);)
// In case there is a race condition between the logic above and the reset_signals task, we make
// sure that the reset also de-asserts the acknowledge signal. It can otherwise get stuck high
// during reset and emit an erroneous acknowledge upon exiting reset.
if (cfg.in_reset) `CB.ack_int <= 1'b0;
endtask

`undef CB
Expand Down
Loading