[otbn,rtl] Register local escalation signals for timing optimization #28815
+201
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etterli
force-pushed
the
local-escalation-cut
branch
from
57c0756 to
fd5312f
Compare
Signals contributing to the local controller escalation signal directly factor into the insn_executing signal inside the otbn_controller.sv. This then drives various commit signals as well as the DMEM request signal (lsu_load_req_o). By cutting these escalation signals, these paths are shortened which results in better timing/area results. Signed-off-by: Pascal Etterli <[email protected]>
etterli
force-pushed
the
local-escalation-cut
branch
from
fd5312f to
dcaedae
Compare
With this change one can tell the checker to tolerate a mismatch on the next RTL to ISS trace comparison. This is useful when FI related tests lead to escalations which fire one cycle delayed. Signed-off-by: Pascal Etterli <[email protected]>
Signed-off-by: Pascal Etterli <[email protected]>
etterli
force-pushed
the
local-escalation-cut
branch
from
b907f56 to
adf9c08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the proposed optimization in #28345.
Signals contributing to the local controller escalation signal directly factor into the insn_executing signal inside the otbn_controller.sv. This then drives various commit signals as well as the DMEM request signal (lsu_load_req_o). By cutting these escalation signals, these paths are shortened which results in better timing/area results.