fix: docker image not building #1724
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipecrs
commented
May 23, 2025
|
Just in case someone else needs this before @lowlighter gets around to merging it, you can use my fork: - uses: felipecrs/metrics@master
with:
use_prebuilt_image: no |
felipecrs
force-pushed
the
fix-docker-build
branch
from
ff8e606 to
2e7b93a
Compare
mikey-
approved these changes
Jun 5, 2025
|
Great work! Like I said before, I have absolutely no sway here - but I've taken a look and approved the changes anyway :) |
SN-Koarashi
added a commit
to SN-Koarashi/metrics
that referenced
this pull request
Jun 29, 2025
|
Sucks I have to switch between forks when a new thing that breaks it happens - hope the tests can get passed and this can be the first commit in 2 years. |
|
This fork broke for me now as well 😔 https://github.com/Kile/Kile/actions/runs/16131614161/job/45519972185 |
|
It has been running ok for me: https://github.com/felipecrs/felipecrs/actions I may fix bugs I encounter, but I have no intention to maintain this fork, by the way. |
|
Hm maybe a fluke. And no worries I don't expect the fork to be maintained. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker image is not currently building, it just gets stuck forever.
I think it's because of some npm scripts.
So, first I updated all dependencies within ranges with
npm update --save, and then I updated puppeteer and sharp to their latest versions.Also, I took this opportunity to modernize the Dockerfile and make it much quicker to build.
Note I removed licensed, but I plan to bring it back once pkgxdev/pantry#9488 is completed.EDIT: done.