Remove redundant check in ID validation logic #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was just an abundance of caution - very keen to avoid path traversal vulnerabilities |
Okay, so you want to leave it there? I still don't really get it's purpose considering the regex. Are there some weird edge cases that I'm not aware of where this simple pattern cannot catch dots? Could you elaborate? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
INVALID_TOKEN_PATTERNcatches the dot character, thepath.contains(".")check appears to be redundant when validating paste ids.Feel free to correct me if I'm wrong or missing something.