Actually use the log file, fixed bad update grep (UNIX) #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For many projects, I have tag files already generated, so I'd like to just update those. However, I noticed that gutentags would only update tag files it generated. The grep command used to remove files wasn't working for some reason, so I updated it. I also updated the script to use the log file it wasn't previously using.
|
Hi and thanks for the PR! I didn't know about those special bracketed names for grep's regex engine, that's nice, thanks. I'm not sure what your regex changes though -- before, it was skipping over any non-tab character up to the first tab, and now you're matching any alpha-numeric character up to the first whitespace. So AFAICT it will fail if a symbol has non-alpha-numeric characters (unlikely, but worth noting) but will also match if the whitespace after it isn't a tab (unlikely, I think that's part of the ctags standard?). I don't understand what you're doing with the redirections, too. Looking it up, I think this use of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For many projects, I have tag files already generated, so I'd like to just update those. However, I noticed that gutentags would only update tag files it generated. The regex pattern used to find the changed file wasn't working for some reason, so I updated it.
I also updated the script to use the log file it wasn't previously using.