Skip to content

Fix table quick filter #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lusingander merged 2 commits into from
Jan 28, 2026
Merged

Fix table quick filter #26

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f649e9
Fix item access in TableView to use view_indices for selected rows
lusingander Jan 28, 2026
ec916b8
Refactor item access in TableView to use current_selected_item method
lusingander Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 34 additions & 26 deletions src/view/table.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ impl TableView {

impl TableView {
fn open_item(&self) {
if let Some(item) = self.items.get(self.table_state.selected_row) {
if let Some(item) = self.current_selected_item() {
let desc = self.table_description.clone();
let item = item.clone();
self.tx.send(AppEvent::OpenItem(desc, item));
Expand All @@ -486,14 +486,15 @@ impl TableView {

fn open_expand_selected_attr(&mut self) {
if let Some(col) = self.table_state.selected_col {
let selected_item = &self.items[self.table_state.selected_row];
let schema = &self.table_description.key_schema_type;
let key = &list_attribute_keys(&self.items, schema)[col];
if let Some(attr) = selected_item.attributes.get(key) {
let lines = get_raw_json_attribute_lines(attr, &self.theme);
let options = self.attr_scroll_lines_state.current_options();
self.attr_scroll_lines_state = ScrollLinesState::new(lines, options);
self.attr_expanded = true;
if let Some(selected_item) = self.current_selected_item() {
let schema = &self.table_description.key_schema_type;
let key = &list_attribute_keys(&self.items, schema)[col];
if let Some(attr) = selected_item.attributes.get(key) {
let lines = get_raw_json_attribute_lines(attr, &self.theme);
let options = self.attr_scroll_lines_state.current_options();
self.attr_scroll_lines_state = ScrollLinesState::new(lines, options);
self.attr_expanded = true;
}
}
}
}
Expand Down Expand Up @@ -606,28 +607,35 @@ impl TableView {
.with_new_total_rows(self.view_indices.len());
}

fn current_selected_item(&self) -> Option<&Item> {
self.view_indices
.get(self.table_state.selected_row)
.and_then(|&idx| self.items.get(idx))
}

fn copy_to_clipboard(&self) {
let selected_item = &self.items[self.table_state.selected_row];
let schema = &self.table_description.key_schema_type;

let (name, content) = if let Some(col) = self.table_state.selected_col {
let key = &list_attribute_keys(&self.items, schema)[col];
if let Some(attr) = selected_item.attributes.get(key) {
if self.attr_expanded {
("selected attribute", get_raw_json_attribute_string(attr))
if let Some(selected_item) = self.current_selected_item() {
let schema = &self.table_description.key_schema_type;

let (name, content) = if let Some(col) = self.table_state.selected_col {
let key = &list_attribute_keys(&self.items, schema)[col];
if let Some(attr) = selected_item.attributes.get(key) {
if self.attr_expanded {
("selected attribute", get_raw_json_attribute_string(attr))
} else {
("selected attribute", attr.to_simple_string())
}
} else {
("selected attribute", attr.to_simple_string())
return;
}
} else {
return;
}
} else {
let raw_json_string = get_raw_json_string(selected_item, schema);
("selected item", raw_json_string)
};
let raw_json_string = get_raw_json_string(selected_item, schema);
("selected item", raw_json_string)
};

self.tx
.send(AppEvent::CopyToClipboard(name.into(), content));
self.tx
.send(AppEvent::CopyToClipboard(name.into(), content));
}
}

fn open_help(&self) {
Expand Down