Add logic to uninstall an application #333
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathias Gibbens <[email protected]>
…nstall Signed-off-by: Mathias Gibbens <[email protected]>
stgraber
reviewed
Sep 17, 2025
Comment on lines
+185
to
+202
| // Remove the sysext image. | ||
| err = os.Remove("/var/lib/extensions/operations-center.raw") | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| // Refresh the system extensions. | ||
| err = systemd.RefreshExtensions(ctx) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| // Reload the systemd daemon. | ||
| err = systemd.ReloadDaemon(ctx) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
There was a problem hiding this comment.
Given the repetition, should we have a systemd.RemoveExtension or something which does those three steps?
|
I'm not sure what the use case for this is, at least for primary applications (incus, operations-center, migration-manager) as the moment you uninstall them, you've got a bricked system. It makes sense for additional applications like debug or the openfga application, but not so much for the primary ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logic to uninstall an application, optionally also removing all relevant user data as well. Extends the
/applications/{name}endpoint to accept aDELETErequest to trigger the removal.